planner/core: fix a panic when select for update on join partition table with normal table #26373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble with normal table
ti-chi-bot
added
the
size/S
qw4990
approved these changes
Jul 20, 2021
zhuo-zhi
approved these changes
Jul 20, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
Closed
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 0c7ff7f
|
ti-chi-bot
added
the
status/can-merge
12 tasks
|
/run-cherry-pick |
12 tasks
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.1 in PR #26563 |
tiancaiamao
added a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 5, 2021
12 tasks
|
Cherry pick to 5.1 branch in #26631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #26250
Problem Summary:
What is changed and how it works?
What's Changed:
Add extra partition column do not consider the case when the DataSource is not a partition table.
How it Works:
Do not add extra partition column when the table is not a partitioned table.
Check List
Tests
Side effects
Documentation
Release note