-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: support retry for mpp query (#26462) #26480
store/copr: support retry for mpp query (#26462) #26480
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@hanfei1991 you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9d83390
|
/merge |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #26462 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/26480
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
In production enviroument, we have sometimes observed that grpc server refuse to serve even though the server replies the IsAlive successfully. This only happens when we kill TiFlash forcely and restart it again. The unsteady time is usually short and TiFlash will serve normal after tens of seconds. We have to introduce a retry mechanism to work it around.
What is changed and how it works?
What's Changed:
We will retry MPPDispatch and MPPEstablishConnection requests after meeting i/o error, util the max backoff time has been reached.
Check List
Tests
Side effects
Documentation
Release note