Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix unexpected behavior when casting invalid string to date #26784

Merged
merged 19 commits into from
Aug 4, 2021
Merged

executor: fix unexpected behavior when casting invalid string to date #26784

merged 19 commits into from
Aug 4, 2021

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Aug 2, 2021 •
edited
Loading

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #26762

Problem Summary: check issue comment

What is changed and how it works?

What's Changed: In table/column.go:CastValue(), only check NoZeroDate when input string is a valid time. Otherwise we may insert zero date unexpectedly in strict mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

  • executor: fix unexpected behavior when casting invalid string to date

@guo-shaoge
executor: fix unexpected behavior when casting invalid string to date
b34f117 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@guo-shaoge: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 2, 2021
@zhouqiang-cl
Copy link
Contributor

/run-integration-tests

zhouqiang-cl and others added 2 commits August 2, 2021 14:15
@zhouqiang-cl
Merge branch 'master' into no_zero_date_bug_fix
6746670
@guo-shaoge
trivial chg
f2c690e 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
chg
eb1a85c 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

@ichn-hu ichn-hu mentioned this pull request Aug 2, 2021
Closed
@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

@guo-shaoge
Copy link
Collaborator Author

/run-integration-common-test
/run-common-test
/run-integration-copr-test

XuHuaiyu
XuHuaiyu approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2021
@wshwsh12
Copy link
Contributor

wshwsh12 commented Aug 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eb1a85c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Aug 3, 2021

/merge

@zhouqiang-cl zhouqiang-cl removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 4, 2021
@ti-chi-bot ti-chi-bot merged commit 31403ad into pingcap:master Aug 4, 2021
@guo-shaoge
Copy link
Collaborator Author

/label needs-cherry-pick-5.0

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 11, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#26784 to release-5.0
1bd9fda 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 11, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #27110

@guo-shaoge
Copy link
Collaborator Author

/label needs-cherry-pick-5.1

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 11, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#26784 to release-5.1
e8e81cf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 11, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27112

ti-chi-bot pushed a commit that referenced this pull request Sep 6, 2021
@ti-srebot
executor: fix unexpected behavior when casting invalid string to date (…
f0b0834 
…#26784) (#27110)
@guo-shaoge
Copy link
Collaborator Author

/label needs-cherry-pick-4.0

@ti-srebot ti-srebot mentioned this pull request Sep 9, 2021
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 9, 2021
@guo-shaoge @ti-srebot
cherry pick pingcap#26784 to release-4.0
7eb76eb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27935

ti-chi-bot pushed a commit that referenced this pull request Sep 13, 2021
@ti-srebot
executor: fix unexpected behavior when casting invalid string to date (…
842cb0c 
…#26784) (#27935)
ti-chi-bot pushed a commit that referenced this pull request Sep 15, 2021
@ti-srebot
executor: fix unexpected behavior when casting invalid string to date (…
ccfb748 
…#26784) (#27112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression issue: sql_mode=STRICT_TRANS_TABLES insert invalid date Successfully
6 participants
@guo-shaoge @ti-chi-bot @zhouqiang-cl @wshwsh12 @XuHuaiyu @ti-srebot