Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the issue that UnionScan returns wrong results in dynamic mode (#26876) #26912

Closed
wants to merge 2 commits into from
Closed

planner: fix the issue that UnionScan returns wrong results in dynamic mode (#26876) #26912

wants to merge 2 commits into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 5, 2021 •
edited
Loading

cherry-pick #26876 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26912

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26912:release-5.1-4d5773c298cb

What problem does this PR solve?

Issue Number: close #26719

Problem Summary: planner: fix the issue that UnionScan returns wrong results in dynamic mode

What is changed and how it works?

planner: fix the issue that UnionScan returns wrong results in dynamic mode

Please see #26719 for more details.

Check List

Tests

  • Unit test

Release note 

planner: fix the issue that UnionScan returns wrong results in dynamic mode

@qw4990 @ti-srebot
cherry pick pingcap#26876 to release-5.1
cbfd4e1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner August 5, 2021 03:25
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot ti-srebot requested review from hanfei1991 and removed request for a team August 5, 2021 03:25
@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 5, 2021
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
Merged
1 task
@ti-srebot ti-srebot added sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.1-cherry-pick type/bugfix This PR fixes a bug. labels Aug 5, 2021
@ti-srebot ti-srebot added this to the v5.1.1 milestone Aug 5, 2021
@ti-srebot
Copy link
Contributor Author

@qw4990 you're already a collaborator in bot's repo.

@qw4990
Copy link
Contributor

qw4990 commented Aug 5, 2021

/run-integration-tests tidb-test=pr/1258

@ti-srebot ti-srebot requested a review from a team as a code owner August 5, 2021 06:42
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team August 5, 2021 06:42
@qw4990
Copy link
Contributor

qw4990 commented Aug 5, 2021

/run-integration-tests tidb-test=pr/1258

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Aug 5, 2021

/run-integration-tests tidb-test=pr/1258

@qw4990
Copy link
Contributor

qw4990 commented Aug 5, 2021

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label Aug 5, 2021
@qw4990
Copy link
Contributor

qw4990 commented Aug 5, 2021

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Aug 5, 2021

/rebuild

@qw4990
Copy link
Contributor

qw4990 commented Aug 5, 2021

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Sep 16, 2021

Close it since dynamic-mode is not GA and there are lots of conflicts.

@qw4990 qw4990 closed this Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

@rebelice rebelice Awaiting requested review from rebelice

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@qw4990 qw4990

Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/5.1-cherry-pick
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @ti-chi-bot @qw4990