-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix compare string with hex string literal makes tidb panic #26964
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
bfb3ad8
to
706f121
Compare
706f121
to
774112c
Compare
44e487f
to
41c5476
Compare
41c5476
to
f5708ec
Compare
f5708ec
to
2a66367
Compare
b8d4ca1
to
ee51e4a
Compare
ee51e4a
to
e0beefb
Compare
/run-build |
/hold |
@xiongjiwei: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number:
close #23507
close #23506
Problem Summary:
What is changed and how it works?
if the function's arguments are constant and string type, we should check its validity, so that this pr will eval string expression at
getfunction
phase if the argument is constant and string type and some error arise earlier, see the changed tests.Check List
Tests
Side effects
Documentation
Release note