Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excutor: fix the date precision of builtinCastDurationAsStringSig.vecEvalString (#23332) #27006

Closed
wants to merge 1 commit into from

Conversation

wzru
Copy link
Contributor

@wzru wzru commented Aug 9, 2021

Signed-off-by: ti-srebot ti-srebot@pingcap.com

cherry-pick #23332 to release-5.0

What problem does this PR solve?

Issue Number: close #26790

Problem Summary:

use test;
drop table if exists t;
create table t(a time(2));
insert into t values("2020-02-02 22:22:22.94");
select length(a),a from t;

release-5.1 & master & mysql 8.0.21(EXPECTED):

mysql> select length(a),a from t;
+-----------+-------------+
| length(a) | a           |
+-----------+-------------+
|        11 | 22:22:22.94 |
+-----------+-------------+
1 row in set (0.00 sec)

release-4.0 & release-5.0:

tidb> select length(a),a from t;
+-----------+-------------+
| length(a) | a           |
+-----------+-------------+
|         8 | 22:22:22.94 |
+-----------+-------------+
1 row in set (0.00 sec)

Release note

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • guo-shaoge

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@wzru wzru requested a review from a team as a code owner August 9, 2021 02:17
@wzru wzru requested review from qw4990 and removed request for a team August 9, 2021 02:17
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 9, 2021
@ti-chi-bot
Copy link
Member

@wzru: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2021
@wzru
Copy link
Contributor Author

wzru commented Aug 9, 2021

/cc @XuHuaiyu @guo-shaoge

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2021
@wzru wzru changed the title expression: cherry pick #23332 to release-5.0 excutor: fix the date precision of builtinCastDurationAsStringSig.vecEvalString #23314 #23286 (#23332) Aug 9, 2021
@XuHuaiyu XuHuaiyu changed the title excutor: fix the date precision of builtinCastDurationAsStringSig.vecEvalString #23314 #23286 (#23332) excutor: fix the date precision of builtinCastDurationAsStringSig.vecEvalString (#23332) Aug 9, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2021
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 46dff7c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@wzru wzru added this to the v5.0.3 milestone Aug 11, 2021
@wzru wzru linked an issue Aug 12, 2021 that may be closed by this pull request
@ichn-hu ichn-hu mentioned this pull request Aug 12, 2021
@XuHuaiyu XuHuaiyu closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

length(time(2)) is not compatible with mysql
5 participants