-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore: remove restore meta sql in create table #27199
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/component br |
/run-integration-tests |
/run-check_dev_2 |
/component br |
/run-check_dev_2 |
/run-check_dev_2 |
/run-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Co-authored-by: kennytm <kennytm@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 87dc81a
|
@YuJuncen: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev_2
|
What problem does this PR solve?
Speed up create tables via omit a DDL job.
Problem Summary:
What is changed and how it works?
What's Changed: Remove all DDLs of rebasing autos.
How it Works: When creating table with
CreateTableWithInfo
, TiDB has rebased the auto ids via the table info:tidb/ddl/ddl_api.go
Lines 1924 to 1937 in a9cba7c
It's no meaning for rebasing the auto ids again.
Check List
Tests
br_views_and_sequences
)Release note