Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add test case for sql binding in the local temporary #27206

Merged
merged 9 commits into from
Aug 17, 2021
Merged

planner: add test case for sql binding in the local temporary #27206

merged 9 commits into from
Aug 17, 2021

Conversation

sylzd
Copy link
Contributor

@sylzd sylzd commented Aug 13, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #25941

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 13, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 13, 2021
@github-actions github-actions bot added the sig/planner SIG: Planner label Aug 13, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Aug 13, 2021

/run-check_dev_2

3 similar comments
@sylzd
Copy link
Contributor Author

sylzd commented Aug 13, 2021

/run-check_dev_2

@sylzd
Copy link
Contributor Author

sylzd commented Aug 13, 2021

/run-check_dev_2

@sylzd
Copy link
Contributor Author

sylzd commented Aug 13, 2021

/run-check_dev_2

@sylzd
Copy link
Contributor Author

sylzd commented Aug 14, 2021

/run-all-tests

@sylzd
Copy link
Contributor Author

sylzd commented Aug 15, 2021

/cc @lcwangchao @tiancaiamao

@ti-chi-bot
Copy link
Member

@tiancaiamao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiancaiamao
Copy link
Contributor

B.T.W, would you like to take a look at this one? @sylzd
#26377

@sylzd
Copy link
Contributor Author

sylzd commented Aug 16, 2021

B.T.W, would you like to take a look at this one? @sylzd
#26377

okay~

@ti-chi-bot
Copy link
Member

@lcwangchao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao lcwangchao added the sig/sql-infra SIG: SQL Infra label Aug 17, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Aug 17, 2021

/merge

@ti-chi-bot
Copy link
Member

@sylzd: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sylzd
Copy link
Contributor Author

sylzd commented Aug 17, 2021

/assign @tiancaiamao @djshow832 merge help~~

@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@djshow832: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2021
@lcwangchao lcwangchao self-requested a review August 17, 2021 08:44
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 307ab01

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Aug 17, 2021

/run-all-tests

@djshow832
Copy link
Contributor

/run-check_dev_2

@djshow832
Copy link
Contributor

I've recorded the data race in #27307 and I'm retrying the CI...

@ti-chi-bot
Copy link
Member

@sylzd: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4a3c290 into pingcap:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forbid SQL binding in local temporary tables
5 participants
@sylzd @ti-chi-bot @tiancaiamao @djshow832 @lcwangchao