expression: forbidden bind sql when subquery or union exists #27347
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note
ti-chi-bot
removed
the
needs-rebase
|
/run-check_dev_2 |
ti-chi-bot
added
release-note-none
| resNode = n.From.TableRefs | ||
| resNode = n | ||
| case *ast.SetOprStmt: | ||
| resNode = n | ||
| case *ast.DeleteStmt: | ||
| resNode = n.TableRefs.TableRefs | ||
| case *ast.UpdateStmt: |
There was a problem hiding this comment.
I think we should also check where expr in Delete/Update
There was a problem hiding this comment.
Let's open a new issue about Delete/Update/Insert~
There was a problem hiding this comment.
ok~ I have created a new issue #27422
There was a problem hiding this comment.
thx a lot, I'm working on it.
| // extractTableList extracts all the TableNames from node. | ||
| // If asName is true, extract AsName prior to OrigName. | ||
| // Privilege check should use OrigName, while expression may use AsName. | ||
| // TODO: extracting all tables by vistor model maybe a better way | ||
| func extractTableList(node ast.ResultSetNode, input []*ast.TableName, asName bool) []*ast.TableName { |
There was a problem hiding this comment.
Maybe we can add a unit test for extractTableList ?
There was a problem hiding this comment.
That's a big project. It seems most internal methods in logic_plan_builder.go do not have a UT, such as extractTableSourceAsNames , extractOnCondition .... and so on. I think it's probably tested by high level.
There was a problem hiding this comment.
Adding a unit test is a better practice to prevent explosion of combinations. So even we have some integration tests we still need unit tests to ensure robustness of our code. But I will approve the pr because it is for forbidden bind sql when subquery or union exists . We may add a unit test for this method in another PR.
There was a problem hiding this comment.
I agree to make a specific project to improve the test coverage about logic_plan_builder.go
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 7306096
|
ti-chi-bot
added
the
status/can-merge
|
/run-check_dev_2 |
|
/run-unit-test |
|
/merge |
|
@zhouqiang-cl: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-check_dev_2 |
|
@sylzd: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-unit-test |
2 similar comments
|
/run-unit-test |
|
/run-unit-test |
What problem does this PR solve?
Issue Number: close #26377
Problem Summary:
When temporary table exits in subquery or be on of setOpr select list, binding sql will be return no error.
What is changed and how it works?
Proposal: xxx
What's Changed:
extractTableListModifiedHow it Works:
extractTableListwill work when subquery, setOpr exits.Check List
Tests
Side effects
Documentation
Release note