Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: add a precheck for csv header #27819

Merged
merged 20 commits into from
Nov 18, 2021
Merged

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Sep 6, 2021

What problem does this PR solve?

Issue Number: close #27757

Problem Summary:

What is changed and how it works?

Verify if source csv files actually contain header line but the config is false

Proposal: xxx

What's Changed:

How it Works:
Try to find a table that satisfy following two restrict:

  • contains at least 1 csv file(2 is prefered)
  • contains a primary key or unique key

If the field values in the source files' first line match the table column names:

  • if there are two source files and the table contains pk/uk, or the value of the fields are not compatible with the table column tables, then precheck report a critical erorr
  • otherwise, report a warning.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Add a precheck for CSV header setting

@glorv glorv added the component/lightning This issue is related to Lightning of TiDB. label Sep 6, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 6, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2021
@kennytm kennytm changed the title br: add a precheck for csv header lightning: add a precheck for csv header Sep 27, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2021
@glorv
Copy link
Contributor Author

glorv commented Nov 2, 2021

/cc @kennytm

br/pkg/lightning/restore/check_info_test.go Show resolved Hide resolved
br/pkg/lightning/restore/check_info.go Outdated Show resolved Hide resolved
br/pkg/lightning/restore/check_info.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM


func checkFieldCompatibility(tbl *model.TableInfo, ignoreCols map[string]struct{}, values []types.Datum) bool {
se := kv.NewSession(&kv.SessionOptions{
SQLMode: mysql.ModeStrictTransTables,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 it should copy the SQL mode from the config, not always using strict_trans_tables, because this affects the CastValue function below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ModeStrictTransTables is by design. the SQL mode in config is likely to be a looser one (like the current default SQL mode of lightning), then failed type cast will be omited. And when the check logic reaches here, it means the values is the same as the row columns names (likely to be strings in the common case), so the possibility of meeting a false positive case (like a field name is 0000-00-00?🤔) is quite low.

br/pkg/lightning/restore/check_info.go Outdated Show resolved Hide resolved
br/pkg/lightning/restore/check_info.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2021
@glorv
Copy link
Contributor Author

glorv commented Nov 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 02b3771

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2021
@ti-chi-bot
Copy link
Member

@glorv: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4a7aad9 into pingcap:master Nov 18, 2021
@glorv glorv deleted the check-csv branch February 28, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/lightning This issue is related to Lightning of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning: add to feature to validate / determine header configuration of csv import
4 participants