-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: add a precheck for csv header #27819
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @kennytm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
|
||
func checkFieldCompatibility(tbl *model.TableInfo, ignoreCols map[string]struct{}, values []types.Datum) bool { | ||
se := kv.NewSession(&kv.SessionOptions{ | ||
SQLMode: mysql.ModeStrictTransTables, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 it should copy the SQL mode from the config, not always using strict_trans_tables
, because this affects the CastValue
function below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ModeStrictTransTables
is by design. the SQL mode in config is likely to be a looser one (like the current default SQL mode of lightning), then failed type cast will be omited. And when the check logic reaches here, it means the values is the same as the row columns names (likely to be strings in the common case), so the possibility of meeting a false positive case (like a field name is 0000-00-00
?🤔) is quite low.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 02b3771
|
@glorv: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #27757
Problem Summary:
What is changed and how it works?
Verify if source csv files actually contain header line but the config is false
Proposal: xxx
What's Changed:
How it Works:
Try to find a table that satisfy following two restrict:
If the field values in the source files' first line match the table column names:
Check List
Tests
Side effects
Documentation
Release note