Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: migrate test-infra to testify(staging-1) #27868

Merged
merged 4 commits into from
Sep 15, 2021
Merged

bindinfo: migrate test-infra to testify(staging-1) #27868

merged 4 commits into from
Sep 15, 2021

Conversation

w169q169
Copy link
Contributor

@w169q169 w169q169 commented Sep 7, 2021 •
edited by tisonkun
Loading

What problem does this PR solve?

Issue Number: to #27177

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 7, 2021
@w169q169
Copy link
Contributor Author

w169q169 commented Sep 8, 2021

/cc @tisonkun

@tisonkun
Copy link
Contributor

tisonkun commented Sep 9, 2021

@w169q169 sorry I'm a bit busy these days. Will review this one tomorrow.

@ti-chi-bot
Copy link
Member

@w169q169: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[This PR modifies significant config files which require review from domain experts.

/cc qw4990 bb7133 XuHuaiyu cfzjywxk morgo
]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tisonkun
Copy link
Contributor

Thanks for your contribution on this branch of code @w169q169 ! It is a glorious contribution.

morgo
morgo requested changes Sep 11, 2021
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Only nit: please rename ClearStatistics4Test to FlushStatistics.

@tisonkun tisonkun self-requested a review September 14, 2021 05:59
tisonkun
tisonkun approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test migration part looks good to me. @morgo please check the ClearStatistics4Test part.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2021
morgo
morgo approved these changes Sep 14, 2021
View reviewed changes
sessionctx/variable/statusvar.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 14, 2021
@morgo
Copy link
Contributor

morgo commented Sep 14, 2021

LGTM, please resolve conflicts and then we can merge!

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2021
@tisonkun
Copy link
Contributor

/assign @morgo

@morgo
Copy link
Contributor

morgo commented Sep 15, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1fba627

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021
@ti-chi-bot
Copy link
Member

@w169q169: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b25a392 into pingcap:master Sep 15, 2021
@w169q169 w169q169 deleted the issue-27177-staging-1 branch September 15, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@morgo morgo morgo approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

@qw4990 qw4990 Awaiting requested review from qw4990

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@morgo morgo

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w169q169 @ti-chi-bot @tisonkun @morgo