-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr: avoid NPE when store is not available when balance batch cop task #28110
copr: avoid NPE when store is not available when balance batch cop task #28110
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/label needs-cherry-pick-5.2 |
/label needs-cherry-pick-5.1 |
/label needs-cherry-pick-5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 50174ec
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #28138 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #28139 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #28140 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: zhouqiang <zhouqiang.cl@gmail.com>
What problem does this PR solve?
Issue Number: close #28096
Problem Summary:
As described in the issue.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause is in L162, it tries to get
err.Error()
even if err is niltidb/store/copr/batch_coprocessor.go
Lines 161 to 167 in b839744
The pr fix it by only get
err.Error()
if err is not nil.Check List
Tests
Side effects
Documentation
Release note