Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: migrate testSerialSuite to testify #28385

Merged
merged 4 commits into from
Sep 27, 2021
Merged

bindinfo: migrate testSerialSuite to testify #28385

merged 4 commits into from
Sep 27, 2021
+133 −119

Conversation

tisonkun
Copy link
Contributor

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Issue Number: ref #27177

Release note

None

@tisonkun
bindinfo: migrate testSerialSuite to testify
39197a0 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • sylzd
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2021
@tisonkun
Copy link
Contributor Author

/cc @sylzd @tiancaiamao

cc @w169q169

@sylzd
Copy link
Contributor

sylzd commented Sep 27, 2021

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2021
@tisonkun
Copy link
Contributor Author

/assign @tiancaiamao

Could you help on merging this PR? Or we require another reviewer?

@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 39197a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2021
@ti-chi-bot ti-chi-bot merged commit 76267b2 into pingcap:master Sep 27, 2021
@tisonkun tisonkun deleted the issue-27177 branch March 4, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@sylzd sylzd sylzd approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees

@tiancaiamao tiancaiamao

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tisonkun @ti-chi-bot @sylzd @djshow832 @tiancaiamao