-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysqldef: save FSP and fix zone offset for codec #29
Merged
+49
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hour, min, sec := t.Time.Clock() | ||
nsec := t.Time.Nanosecond() | ||
_, offset := time.Date(year, month, day, hour, min, sec, nsec, time.Local).Zone() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about _, offset := t.Time.In(time.Local).Zone()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it works
LGTM |
siddontang
changed the title
mysqldef: save FSP and zone offset for codec
mysqldef: save FSP and fix zone offset for codec
Sep 7, 2015
LGTM |
siddontang
added a commit
that referenced
this pull request
Sep 7, 2015
mysqldef: save FSP and fix zone offset for codec
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* truncate range ts Signed-off-by: 5kbpers <tangminghua@pingcap.com> * fix downlaod request range Signed-off-by: 5kbpers <tangminghua@pingcap.com>
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
Signed-off-by: zhongzc <zhongzc_arch@outlook.com>
Connor1996
pushed a commit
to Connor1996/tidb
that referenced
this pull request
Dec 14, 2022
Signed-off-by: nolouch <nolouch@gmail.com>
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
… ongoing txn (pingcap#32111) (pingcap#48905) (pingcap#29) close pingcap#32110 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coocood @qiuyesuifeng