Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Support GBK for builtin function AesDecrypt #29157

Merged
merged 24 commits into from
Nov 15, 2021
Merged

expression: Support GBK for builtin function AesDecrypt #29157

merged 24 commits into from
Nov 15, 2021

Conversation

unconsolable
Copy link
Contributor

@unconsolable unconsolable commented Oct 27, 2021 •
edited
Loading

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

What problem does this PR solve?

Issue Number: close #29156

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@unconsolable
Support GBK for builtin function AesDecrypt
dd380c3 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xiongjiwei
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
@unconsolable
remove aes_decrypt explain test case for binary
325efd7 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
Copy link
Contributor Author

/cc @xiongjiwei @zimulala
PTAL

xiongjiwei
xiongjiwei reviewed Oct 27, 2021
View reviewed changes
expression/builtin_encryption_vec.go Outdated Show resolved Hide resolved
expression/builtin_encryption_vec.go Outdated Show resolved Hide resolved
expression/builtin_encryption_vec.go Outdated Show resolved Hide resolved
@unconsolable
add inline & encodedBuf, move code
e62b760 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
inline in builtin_encryption.go
748d9dc 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable unconsolable mentioned this pull request Oct 27, 2021
Merged
2 tasks
@unconsolable
Merge branch 'master' into issue-29156
0bc9281
@unconsolable
gofmt
edb0cc3 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
migrate test
b29a617 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
add spare buf for iv, add test for builtinAesDecryptIVSig
ea14f20 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
replace convert to hex, fix error handling
dac286b 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
fix typo
8a0f6d3 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
Merge branch 'pingcap:master' into issue-29156
837fb25
@unconsolable
fix error
8b24972 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
Merge branch 'master' into issue-29156
aaaeddb
@unconsolable
fix explain_test
d46473f 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2021
@xiongjiwei
Copy link
Contributor

/cc @tangenta @zimulala

@unconsolable
fix explain test
cdecd2d 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
Merge branch 'master' into issue-29156
47bb54d
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2021
@unconsolable
fix explain test
2017b92 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2021
@unconsolable
Copy link
Contributor Author

/cc @AilinKid
Please help on review when available, thanks~

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2021
@unconsolable
fix explain test
2583d88 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
fix test error
3fae979 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2021
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 7, 2021
@zimulala
Copy link
Contributor

Please address comments.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
@unconsolable
fix explain
6671cff 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable
Copy link
Contributor Author

Please address comments.

Resolved

zimulala
zimulala approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2021
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6671cff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021
@ti-chi-bot
Copy link
Member

@unconsolable: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8bdac02 into pingcap:master Nov 15, 2021
@unconsolable unconsolable deleted the issue-29156 branch November 15, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@zimulala zimulala zimulala approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GBK for builtin function AesDecrypt
4 participants
@unconsolable @ti-chi-bot @xiongjiwei @zimulala