Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix wrong result for join with enum type #29375

Merged
merged 11 commits into from
Nov 5, 2021
Merged

executor: fix wrong result for join with enum type #29375

merged 11 commits into from
Nov 5, 2021

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Nov 3, 2021

What problem does this PR solve?

Issue Number: close #27831

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix wrong result for join with enum type

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2021
@wshwsh12 wshwsh12 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2021
@wshwsh12 wshwsh12 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2021
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Nov 5, 2021

/cc @guo-shaoge

lzmhhh123
lzmhhh123 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 5, 2021
@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Nov 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f8c2b87

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2021
@ti-chi-bot ti-chi-bot merged commit fa8cbd5 into pingcap:master Nov 5, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#29375 to release-5.1
df78849 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 5, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #29514

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#29375 to release-5.2
a968701 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 5, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #29515

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#29375 to release-5.3
142a3d0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 5, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #29516

ti-chi-bot pushed a commit that referenced this pull request Nov 8, 2021
@ti-srebot
executor: fix wrong result for join with enum type (#29375) (#29516)
363ff6e
ti-chi-bot pushed a commit that referenced this pull request Jan 29, 2022
@ti-srebot
executor: fix wrong result for join with enum type (#29375) (#29514)
1d6b5bb 
close #27831
@tiancaiamao tiancaiamao mentioned this pull request Apr 12, 2022
Closed
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2022
@ti-srebot
executor: fix wrong result for join with enum type (#29375) (#29515)
fb4741d 
close #27831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong result in the combined expression
5 participants
@wshwsh12 @ti-chi-bot @ti-srebot @lzmhhh123 @ichn-hu