executor: send a task with error to the resultCh when panic happen (#30214) #30241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
ti-chi-bot
added
do-not-merge/cherry-pick-not-approved
do-not-merge/release-note-label-needed
1 task
ti-chi-bot
removed
the
do-not-merge/release-note-label-needed
ti-srebot
added
component/executor
size/M
|
@XuHuaiyu you're already a collaborator in bot's repo. |
guo-shaoge
approved these changes
Nov 30, 2021
wshwsh12
approved these changes
Nov 30, 2021
ti-chi-bot
added
status/LGT2
zhouqiang-cl
added
the
cherry-pick-approved
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 44076a9
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #30214 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30241After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #30211
Problem Summary:
What is changed and how it works?
A code line is mistakenly deleted, add it back and add a test case to protect it.
Check List
Tests
Side effects
N/A
Documentation
/AN
Release note