-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: make projection executor unparallel for insert/update/delete (#30290) #30388
executor: make projection executor unparallel for insert/update/delete (#30290) #30388
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@tiancaiamao you're already a collaborator in bot's repo. |
/run-check_dev |
/run-mysql-test |
PTAL @coocood |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c5c7da8
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4423c69d5667b93cf82ac0bb9d460ec282a247f9 |
cherry-pick #30290 to release-5.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30388
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #26832
Problem Summary:
The memdb is not thread-safe, and that's the root cause of issue 26832
What is changed and how it works?
In insert/update/delete statement, do not use the parallel projection, choose the unparallel one intead.
This can avoid the concurrent visit of the memdb in issue 26832.
Check List
Tests
I try to add some unit test code like this and run it with
-race
flag, but can't reproduce.and then, I try the TPCC on my local machine, and with no luck ... it doesn't reproduce
This change is simple enough, so maybe we can merge it first and see whether it reproduce in the future.
Side effects
It should not impact the write performance in most cases, because the insert/update/delete is unparalleled
and be the bottleneck, the change of projection does't change this fact.
Documentation
Release note