Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make all the tests run in serial #30692

Merged
merged 2 commits into from
Dec 14, 2021
Merged

test: make all the tests run in serial #30692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55b20f2
test: make all the tests run in serial
tangenta Dec 14, 2021
7a63bde
Makefile: set timeout to 20 min
tangenta Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ devgotest: failpoint-enable
gotest: failpoint-enable
@echo "Running in native mode."
@export log_level=info; export TZ='Asia/Shanghai'; \
$(GOTEST) -ldflags '$(TEST_LDFLAGS)' $(EXTRA_TEST_ARGS) -cover $(PACKAGES_TIDB_TESTS) -coverprofile=coverage.txt -check.p true > gotest.log || { $(FAILPOINT_DISABLE); cat 'gotest.log'; exit 1; }
$(GOTEST) -ldflags '$(TEST_LDFLAGS)' $(EXTRA_TEST_ARGS) -timeout 20m -cover $(PACKAGES_TIDB_TESTS) -coverprofile=coverage.txt -check.p true > gotest.log || { $(FAILPOINT_DISABLE); cat 'gotest.log'; exit 1; }
@$(FAILPOINT_DISABLE)

gotest_in_verify_ci_part_1: failpoint-enable tools/bin/gotestsum tools/bin/gocov tools/bin/gocov-xml
Expand Down
4 changes: 0 additions & 4 deletions br/pkg/conn/conn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,6 @@ func TestCheckStoresAlive(t *testing.T) {
}

func TestGetAllTiKVStores(t *testing.T) {
t.Parallel()

testCases := []struct {
stores []*metapb.Store
storeBehavior StoreBehavior
Expand Down Expand Up @@ -258,8 +256,6 @@ func TestGetAllTiKVStores(t *testing.T) {
}

func TestGetConnOnCanceledContext(t *testing.T) {
t.Parallel()

ctx, cancel := context.WithCancel(context.Background())
cancel()

Expand Down
4 changes: 0 additions & 4 deletions br/pkg/kv/checksum_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ import (
func uint64NotEqual(a uint64, b uint64) bool { return a != b }

func TestChecksum(t *testing.T) {
t.Parallel()

checksum := kv.NewKVChecksum(0)
require.Equal(t, uint64(0), checksum.Sum())

Expand Down Expand Up @@ -69,8 +67,6 @@ func TestChecksum(t *testing.T) {
}

func TestChecksumJSON(t *testing.T) {
t.Parallel()

testStruct := &struct {
Checksum kv.Checksum
}{
Expand Down
4 changes: 0 additions & 4 deletions br/pkg/kv/kv_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ import (
)

func TestMarshal(t *testing.T) {
t.Parallel()

dats := make([]types.Datum, 4)
dats[0].SetInt64(1)
dats[1].SetNull()
Expand All @@ -43,8 +41,6 @@ func TestMarshal(t *testing.T) {
}

func TestSimplePairIter(t *testing.T) {
t.Parallel()

pairs := []Pair{
{Key: []byte("1"), Val: []byte("a")},
{Key: []byte("2"), Val: []byte("b")},
Expand Down
2 changes: 0 additions & 2 deletions br/pkg/kv/session_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import (
)

func TestSession(t *testing.T) {
t.Parallel()

session := newSession(&SessionOptions{SQLMode: mysql.ModeNone, Timestamp: 1234567890, RowFormatVersion: "1"})
_, err := session.Txn(true)
require.NoError(t, err)
Expand Down
15 changes: 0 additions & 15 deletions br/pkg/lightning/backend/backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ func (s *backendSuite) tearDownTest() {
}

func TestOpenCloseImportCleanUpEngine(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()
ctx := context.Background()
Expand Down Expand Up @@ -72,7 +71,6 @@ func TestOpenCloseImportCleanUpEngine(t *testing.T) {
}

func TestUnsafeCloseEngine(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -94,7 +92,6 @@ func TestUnsafeCloseEngine(t *testing.T) {
}

func TestUnsafeCloseEngineWithUUID(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -116,7 +113,6 @@ func TestUnsafeCloseEngineWithUUID(t *testing.T) {
}

func TestWriteEngine(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand Down Expand Up @@ -155,7 +151,6 @@ func TestWriteEngine(t *testing.T) {
}

func TestWriteToEngineWithNothing(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -179,7 +174,6 @@ func TestWriteToEngineWithNothing(t *testing.T) {
}

func TestOpenEngineFailed(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -193,7 +187,6 @@ func TestOpenEngineFailed(t *testing.T) {
}

func TestWriteEngineFailed(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand Down Expand Up @@ -221,7 +214,6 @@ func TestWriteEngineFailed(t *testing.T) {
}

func TestWriteBatchSendFailedWithRetry(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand Down Expand Up @@ -249,7 +241,6 @@ func TestWriteBatchSendFailedWithRetry(t *testing.T) {
}

func TestImportFailedNoRetry(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -268,7 +259,6 @@ func TestImportFailedNoRetry(t *testing.T) {
}

func TestImportFailedWithRetry(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -289,7 +279,6 @@ func TestImportFailedWithRetry(t *testing.T) {
}

func TestImportFailedRecovered(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -312,7 +301,6 @@ func TestImportFailedRecovered(t *testing.T) {

//nolint:interfacer // change test case signature causes check panicking.
func TestClose(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -322,7 +310,6 @@ func TestClose(t *testing.T) {
}

func TestMakeEmptyRows(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -332,7 +319,6 @@ func TestMakeEmptyRows(t *testing.T) {
}

func TestNewEncoder(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand All @@ -346,7 +332,6 @@ func TestNewEncoder(t *testing.T) {
}

func TestCheckDiskQuota(t *testing.T) {
t.Parallel()
s := createBackendSuite(t)
defer s.tearDownTest()

Expand Down
5 changes: 0 additions & 5 deletions br/pkg/lightning/backend/importer/importer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ func (s *importerSuite) tearDownTest() {
}

func TestWriteRows(t *testing.T) {
t.Parallel()
s := createImportSuite(t)
defer s.tearDownTest()

Expand Down Expand Up @@ -117,7 +116,6 @@ func TestWriteRows(t *testing.T) {
}

func TestWriteHeadSendFailed(t *testing.T) {
t.Parallel()
s := createImportSuite(t)
defer s.tearDownTest()

Expand All @@ -142,7 +140,6 @@ func TestWriteHeadSendFailed(t *testing.T) {
}

func TestWriteBatchSendFailed(t *testing.T) {
t.Parallel()
s := createImportSuite(t)
defer s.tearDownTest()

Expand Down Expand Up @@ -174,7 +171,6 @@ func TestWriteBatchSendFailed(t *testing.T) {
}

func TestWriteCloseFailed(t *testing.T) {
t.Parallel()
s := createImportSuite(t)
defer s.tearDownTest()

Expand Down Expand Up @@ -206,7 +202,6 @@ func TestWriteCloseFailed(t *testing.T) {
}

func TestCloseImportCleanupEngine(t *testing.T) {
t.Parallel()
s := createImportSuite(t)
defer s.tearDownTest()

Expand Down
11 changes: 0 additions & 11 deletions br/pkg/lightning/backend/tidb/tidb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ func (s *mysqlSuite) TearDownTest(t *testing.T) {
}

func TestWriteRowsReplaceOnDup(t *testing.T) {
t.Parallel()
s := createMysqlSuite(t)
defer s.TearDownTest(t)
s.mockDB.
Expand Down Expand Up @@ -132,7 +131,6 @@ func TestWriteRowsReplaceOnDup(t *testing.T) {
}

func TestWriteRowsIgnoreOnDup(t *testing.T) {
t.Parallel()
s := createMysqlSuite(t)
defer s.TearDownTest(t)
s.mockDB.
Expand Down Expand Up @@ -179,7 +177,6 @@ func TestWriteRowsIgnoreOnDup(t *testing.T) {
}

func TestWriteRowsErrorOnDup(t *testing.T) {
t.Parallel()
s := createMysqlSuite(t)
defer s.TearDownTest(t)
s.mockDB.
Expand Down Expand Up @@ -259,7 +256,6 @@ func testStrictMode(t *testing.T) {
}

func TestFetchRemoteTableModels_3_x(t *testing.T) {
t.Parallel()
s := createMysqlSuite(t)
defer s.TearDownTest(t)
s.mockDB.ExpectBegin()
Expand Down Expand Up @@ -294,7 +290,6 @@ func TestFetchRemoteTableModels_3_x(t *testing.T) {
}

func TestFetchRemoteTableModels_4_0(t *testing.T) {
t.Parallel()
s := createMysqlSuite(t)
defer s.TearDownTest(t)
s.mockDB.ExpectBegin()
Expand Down Expand Up @@ -332,7 +327,6 @@ func TestFetchRemoteTableModels_4_0(t *testing.T) {
}

func TestFetchRemoteTableModels_4_x_auto_increment(t *testing.T) {
t.Parallel()
s := createMysqlSuite(t)
defer s.TearDownTest(t)
s.mockDB.ExpectBegin()
Expand Down Expand Up @@ -370,7 +364,6 @@ func TestFetchRemoteTableModels_4_x_auto_increment(t *testing.T) {
}

func TestFetchRemoteTableModels_4_x_auto_random(t *testing.T) {
t.Parallel()
s := createMysqlSuite(t)
defer s.TearDownTest(t)
s.mockDB.ExpectBegin()
Expand Down Expand Up @@ -410,7 +403,6 @@ func TestFetchRemoteTableModels_4_x_auto_random(t *testing.T) {
}

func TestWriteRowsErrorNoRetry(t *testing.T) {
t.Parallel()
nonRetryableError := sql.ErrNoRows
s := createMysqlSuite(t)
defer s.TearDownTest(t)
Expand All @@ -436,7 +428,6 @@ func TestWriteRowsErrorNoRetry(t *testing.T) {
}

func TestWriteRowsErrorDowngradingAll(t *testing.T) {
t.Parallel()
nonRetryableError := sql.ErrNoRows
s := createMysqlSuite(t)
defer s.TearDownTest(t)
Expand Down Expand Up @@ -503,7 +494,6 @@ func TestWriteRowsErrorDowngradingAll(t *testing.T) {
}

func TestWriteRowsErrorDowngradingExceedThreshold(t *testing.T) {
t.Parallel()
nonRetryableError := sql.ErrNoRows
s := createMysqlSuite(t)
defer s.TearDownTest(t)
Expand Down Expand Up @@ -608,7 +598,6 @@ func encodeRowsTiDB(t *testing.T, b backend.Backend, tbl table.Table) kv.Rows {
}

func TestEncodeRowForRecord(t *testing.T) {
t.Parallel()
s := createMysqlSuite(t)

// for a correct row, the will encode a correct result
Expand Down
Loading