-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add an unit test case for unreasonable invoking Close (#30696) #30768
executor: add an unit test case for unreasonable invoking Close (#30696) #30768
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@XuHuaiyu you're already a collaborator in bot's repo. |
/merge |
/run-check_dev |
/merge |
@XuHuaiyu Seems there is an error on ci |
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1716233
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 68ece70
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5482ef4
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #30696 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30768
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Inspired by #27125, #30587, and #30289, there is a common problem that the
Close
function may be invoked but theOpen
function is not invoked or returned with an error. In this senario, some member attributes are not initialized and the nil pointer panic triggered when invokingClose
.I add a unit test in this commit to test invoking the
Close
function directly without invoking theOpen
function before.With this test, 3 more similar bugs are also found in
MergeJoinExec
,CTEExec
,IndexReader
.What is changed and how it works?
Check List
Tests
Side effects
N/A
Documentation
N/A
Release note