ddl: Implement basic version of TiFlash replica management #30842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
|
/run-unit-test |
|
/run-unit-test |
|
/run-tics-test |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
|
/unhold |
ti-chi-bot
removed
the
do-not-merge/hold
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
/run-all-tests |
|
/run-integration-test-mysql-8026 |
|
/run-unit-test |
|
/run-integration-test |
|
/test ? |
|
/retest |
|
/run-all-tests |
|
/merge cancel |
ti-chi-bot
removed
the
status/can-merge
|
retrigger testing |
|
This pull request has been accepted and is ready to merge. Commit hash: 1f7ffd5
|
ti-chi-bot
added
the
status/can-merge
hawkingrei
reviewed
Jan 19, 2022
| cluster *unistore.Cluster | ||
| } | ||
|
|
||
| var _ = SerialSuites(&tiflashDDLTestSuite{}) |
There was a problem hiding this comment.
We have used the new framework testify to implement test cases instead of pingcap/check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #29924
Problem Summary:
This PR is the second PR to fix problems described in #29924.
It implements basic function of TiFlash replica management. The whole implementation does not include any optimization, which will be introduced in later PRs.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note