Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: not use the latest schema when plan-cache is off #30959

Merged
merged 3 commits into from
Dec 23, 2021
Merged

planner: not use the latest schema when plan-cache is off #30959

merged 3 commits into from
Dec 23, 2021

Conversation

you06
Copy link
Contributor

@you06 you06 commented Dec 23, 2021 •
edited
Loading

Signed-off-by: you06 you1474600@gmail.com

What problem does this PR solve?

Issue Number: close #30940

Problem Summary:

What is changed and how it works?

Execute statements may use different schemas in building plan and execution, this issue is fixed in master by #26759, but hard to cherry-pick to 5.0 branch. Since plan cache is an experimental feature in 5.0, this PR skips fetching the latest schema for non-plan-cache statements.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix a bug that concurrent DML and DDL may cause panic.

@you06
do not use the latest schema for cache miss
8f509e0 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • wjhuang2016
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 23, 2021
@you06
Copy link
Contributor Author

you06 commented Dec 23, 2021

@xhebox PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2021
@you06
Copy link
Contributor Author

you06 commented Dec 23, 2021

@bb7133 @wjhuang2016 PTAL

@bb7133
Copy link
Member

bb7133 commented Dec 23, 2021

Please add a test case for this change.

@bb7133 bb7133 added the require-LGT3 Indicates that the PR requires three LGTM. label Dec 23, 2021
@bb7133
Copy link
Member

bb7133 commented Dec 23, 2021

PTAL @qw4990 @cfzjywxk

AilinKid
AilinKid reviewed Dec 23, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@you06
add test and comment
c5d939e 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 23, 2021
cfzjywxk
cfzjywxk reviewed Dec 23, 2021
View reviewed changes
planner/optimize.go Outdated Show resolved Hide resolved
@you06
format code
d18e6a5 
Signed-off-by: you06 <you1474600@gmail.com>
bb7133
bb7133 reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Dec 23, 2021
@you06
Copy link
Contributor Author

you06 commented Dec 23, 2021

/merge

@ti-chi-bot
Copy link
Member

@you06: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d18e6a5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 23, 2021
@ti-chi-bot ti-chi-bot merged commit 6416f8d into pingcap:release-5.0 Dec 23, 2021
@AilinKid
Copy link
Contributor

/run-cherry-picker

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 19, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.1: #40046.

ti-chi-bot added a commit that referenced this pull request Dec 19, 2022
@ti-chi-bot
planner: not use the latest schema when plan-cache is off (#30959) (#…
48145ba 
…40046)

close #30940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@cfzjywxk cfzjywxk cfzjywxk left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-cherry-pick-release-5.1 release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT3 Indicates that the PR requires three LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@you06 @ti-chi-bot @bb7133 @cfzjywxk @AilinKid @xhebox @wjhuang2016 @zhouqiang-cl