-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: do not overwrite the log config in other tests #31019
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/771fd4ce3992b071b601407baad19351a6c2081f |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7e2f6da
|
@tangenta: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/hold |
/merge cancel because the CI is overload. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cc4b7fb
|
/unhold |
/run-mysql-test |
What problem does this PR solve?
Issue Number: related to #30871.
Problem Summary: #30871 sets the log level to a value read from the env variable
log_level
for every test package. However, some of the package overwrite the log config in tests. The log level in tests is out of control:$ log_level=warn go test -v github.com/pingcap/tidb/server -test.run TestExplainFor -count 1
It is still printing the "INFO" level log:
What is changed and how it works?
This PR tries to prevent the log-config from being overwritten unexpectedly.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
After this PR, only WARN level log is printed:
No code
Side effects
Documentation
Release note