-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: do not use like to build range when new collation is enabled #31278
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@Reminiscent Please update the test cases:
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fd30ef2a0d3e60dccae22ce6f1900fe799edb680 |
@tangenta Update. PTAL |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6c9ae01
|
/run-unit-test |
1 similar comment
/run-unit-test |
/run-cherry-picker release-5.2 |
What problem does this PR solve?
Issue Number: close #31174
Problem Summary:
The like condition will be used to build range, but it can not handle some situations.
What is changed and how it works?
You can see here for more details. But in this PR, we only forbid using the like condition to build range when new collation is enabled and the column type is non-binary collation string.
Check List
Tests
Side effects
Documentation
Release note