Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charset: add gbk_bin collation into gbk charaset #31309

Merged
merged 3 commits into from
Jan 5, 2022
Merged

charset: add gbk_bin collation into gbk charaset #31309

merged 3 commits into from
Jan 5, 2022
+4 −0

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #31308

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 5, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 5, 2022
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74aa058

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2022
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@sre-bot
Copy link
Contributor

sre-bot commented Jan 5, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6977e4c44bc9fd444c083b648e6674a2f64db600

@xiongjiwei
Copy link
Contributor Author

/run-unit-test

1 similar comment
@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@Defined2014
Copy link
Contributor

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 29c398c into pingcap:master Jan 5, 2022
@tiancaiamao tiancaiamao added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Apr 26, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@xiongjiwei @ti-srebot
cherry pick pingcap#31309 to release-5.4
7a7bcc1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34231

@xiongjiwei xiongjiwei deleted the gbk-bin-collation branch September 23, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create GBK table with collation
7 participants
@xiongjiwei @ti-chi-bot @sre-bot @Defined2014 @ti-srebot @tangenta @tiancaiamao