Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add more test cases for plan cache aware of binding #31728

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Jan 17, 2022

What problem does this PR solve?

Issue Number: ref #29539

Problem Summary:
add more test cases for plan cache aware of binding

What is changed and how it works?

  1. session binding and global binding
  2. prepare for ddl statements
  3. capture binding
  4. delete binding
  5. can not create binding because of the using syntax

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner epic/plan-cache labels Jan 17, 2022
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 17, 2022
@zhouqiang-cl
Copy link
Contributor

/rebuild

@sre-bot
Copy link
Contributor

sre-bot commented Jan 18, 2022

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2022
@ti-chi-bot
Copy link
Member

@Reminiscent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rebelice rebelice removed their request for review October 9, 2022 02:51
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8198%. Comparing base (ab30467) to head (5a3be9c).
Report is 8329 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #31728        +/-   ##
================================================
+ Coverage   62.9413%   63.8198%   +0.8785%     
================================================
  Files           774        774                
  Lines        256345     256345                
================================================
+ Hits         161347     163599      +2252     
+ Misses        82023      79719      -2304     
- Partials      12975      13027        +52     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/plan-cache needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants