*: add show push down for ShowTables #31919

hawkingrei · 2022-01-24T06:57:37Z

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #30803

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-01-24T06:57:38Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

tiancaiamao
zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sre-bot · 2022-01-24T07:12:13Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cf0d9ab8afd33c4717c026052aadb1cd6ab16412

hawkingrei · 2022-01-24T07:30:59Z

/run-mysql-test

hawkingrei · 2022-01-24T08:09:55Z

/run-mysql-test

hawkingrei · 2022-01-24T10:48:43Z

/run-unit-test

hawkingrei · 2022-01-24T11:29:14Z

/run-unit-test

hawkingrei · 2022-01-24T14:20:51Z

/run-unit-test

planner/core/planbuilder.go

hawkingrei · 2022-01-25T04:28:21Z

/run-check_dev

zimulala · 2022-01-26T02:50:41Z

planner/core/show_predicate_extractor.go

+			// It is used in `SHOW TABLE in t LIKE `abc``.
+			ptn := pattern.Pattern.(*driver.ValueExpr).GetString()
+			patValue, patTypes := stringutil.CompilePattern(ptn, pattern.Escape)
+			if !collate.NewCollationEnabled() && stringutil.IsExactMatch(patTypes) {


I don't quite understand. Why do you need this logic of !collate.NewCollationEnabled()? Please help to explain it.

It is copied from planner/core/expression_rewriter.go:1634.

Treat predicate 'like' the same way as predicate '=' when it is an exact match and new collation is not enabled.

Could remove this if statement, then use CompileLike2Regexp directly?

OK, I will remove NewCollationEnabled condition. but IsExactMatch still retained. Equal is faster than regexp.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

Co-authored-by: Lynn <zimu_xia@126.com>

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

zimulala

LGTM

zimulala · 2022-01-26T09:05:35Z

/merge

ti-chi-bot · 2022-01-26T09:05:39Z

This pull request has been accepted and is ready to merge.

Commit hash: 8245dc2

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2022-03-23T05:17:24Z

cherry pick to release-5.4 in PR #33338

close #30803

e1ijah1 · 2022-05-24T15:25:24Z

executor/show.go

 		// Test with mysql.AllPrivMask means any privilege would be OK.
 		// TODO: Should consider column privileges, which also make a table visible.
 		if checker != nil && !checker.RequestVerification(activeRoles, e.DBName.O, v.Meta().Name.O, "", mysql.AllPrivMask) {
 			continue
+		} else if FieldFilterEnable && v.Meta().Name.L != fieldFilter {
+			continue
+		} else if fieldPatternsRegexp != nil && !fieldPatternsRegexp.MatchString(v.Meta().Name.L) {


I don't get it. Can we use the original string of meta info instead of the lower case string to match the pattern? Plz help to explain it. @hawkingrei

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2022

hawkingrei force-pushed the add_push_down_for_showtables branch from c0a1e18 to fe13415 Compare January 24, 2022 07:56

hawkingrei requested review from zimulala, tangenta and djshow832 January 24, 2022 08:42

tiancaiamao approved these changes Jan 24, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 24, 2022

zimulala reviewed Jan 25, 2022

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

hawkingrei requested a review from zimulala January 25, 2022 04:23

zimulala reviewed Jan 26, 2022

View reviewed changes

hawkingrei and others added 7 commits January 26, 2022 16:47

*: add show push down for ShowTables

949e4d1

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

test full tables

8ba5e06

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

*: delete duplicate operations

f5c76c1

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

*: fix comment

9b492c5

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

*: add test for plan stringer

eb77e6b

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

Update planner/core/planbuilder.go

b333424

Co-authored-by: Lynn <zimu_xia@126.com>

remove new collation conditional

8245dc2

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>

hawkingrei force-pushed the add_push_down_for_showtables branch from d610b15 to 8245dc2 Compare January 26, 2022 08:48

zimulala approved these changes Jan 26, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022

ti-chi-bot and others added 6 commits January 26, 2022 17:18

Merge branch 'master' into add_push_down_for_showtables

7010586

Merge branch 'master' into add_push_down_for_showtables

5177506

Merge branch 'master' into add_push_down_for_showtables

a8ac05c

Merge branch 'master' into add_push_down_for_showtables

43362c6

Merge branch 'master' into add_push_down_for_showtables

6b04dc6

Merge branch 'master' into add_push_down_for_showtables

cf0d9ab

ti-chi-bot merged commit 93454da into pingcap:master Jan 26, 2022

hawkingrei added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 23, 2022

ti-srebot mentioned this pull request Mar 23, 2022

*: add show push down for ShowTables (#31919) #33338

Merged

12 tasks

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 23, 2022

cherry pick pingcap#31919 to release-5.4

ab5fc46

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-chi-bot pushed a commit that referenced this pull request Mar 31, 2022

*: add show push down for ShowTables (#31919) (#33338)

b1c5a67

close #30803

This was referenced May 24, 2022

SHOW DATABASES LIKE should be case insensitive #34766

Closed

SHOW TABLE STATUS case sensitivity #7518

Closed

e1ijah1 reviewed May 24, 2022

View reviewed changes

likzn mentioned this pull request May 31, 2022

*: support SHOW TABLE STATUS with case insensitivity #35086

Merged

12 tasks

ti-srebot mentioned this pull request Jun 1, 2022

*: support SHOW TABLE STATUS with case insensitivity (#35086) #35115

Closed

12 tasks

likzn mentioned this pull request Jun 6, 2022

ddl: make output field name in show tables/databases stmt compatible with mysql #35136

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: add show push down for ShowTables #31919

*: add show push down for ShowTables #31919

hawkingrei commented Jan 24, 2022

ti-chi-bot commented Jan 24, 2022 •

edited

Loading

sre-bot commented Jan 24, 2022 •

edited

Loading

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 25, 2022

zimulala Jan 26, 2022 •

edited

Loading

hawkingrei Jan 26, 2022

zimulala Jan 26, 2022

hawkingrei Jan 26, 2022

zimulala Jan 26, 2022

zimulala left a comment

zimulala commented Jan 26, 2022

ti-chi-bot commented Jan 26, 2022

ti-srebot commented Mar 23, 2022

e1ijah1 May 24, 2022

*: add show push down for ShowTables #31919

*: add show push down for ShowTables #31919

Conversation

hawkingrei commented Jan 24, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jan 24, 2022 • edited Loading

sre-bot commented Jan 24, 2022 • edited Loading

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 24, 2022

hawkingrei commented Jan 25, 2022

zimulala Jan 26, 2022 • edited Loading

Choose a reason for hiding this comment

hawkingrei Jan 26, 2022

Choose a reason for hiding this comment

zimulala Jan 26, 2022

Choose a reason for hiding this comment

hawkingrei Jan 26, 2022

Choose a reason for hiding this comment

zimulala Jan 26, 2022

Choose a reason for hiding this comment

zimulala left a comment

Choose a reason for hiding this comment

zimulala commented Jan 26, 2022

ti-chi-bot commented Jan 26, 2022

ti-srebot commented Mar 23, 2022

e1ijah1 May 24, 2022

Choose a reason for hiding this comment

ti-chi-bot commented Jan 24, 2022 •

edited

Loading

sre-bot commented Jan 24, 2022 •

edited

Loading

zimulala Jan 26, 2022 •

edited

Loading