Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: migrate test-infra to testify for db_partition_test #32214

Merged
merged 8 commits into from
Mar 3, 2022
Merged

ddl: migrate test-infra to testify for db_partition_test #32214

merged 8 commits into from
Mar 3, 2022

Conversation

hawkingrei
Copy link
Member

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #28635

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 9, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2022
@hawkingrei hawkingrei force-pushed the db_partition_test branch 3 times, most recently from fbdae3a to 956022e Compare February 11, 2022 04:19
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei hawkingrei force-pushed the db_partition_test branch 2 times, most recently from 8937d84 to dae330f Compare February 20, 2022 10:10
@hawkingrei
Copy link
Member Author

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-all-tests

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei hawkingrei force-pushed the db_partition_test branch 3 times, most recently from ee7b3b6 to 6ad4d80 Compare March 3, 2022 08:08
@hawkingrei
Copy link
Member Author

/run-unit-test

2 similar comments
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/20d446b3d9e79ca8f4093f602325e5453ef22c19

@hawkingrei
session: migrate test-infra to testify for pessimistic_test.go
1f0e904 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
ddl: migrate test-infra to testify for db_partition_test
4c16909 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
ddl: migrate test-infra to testify for db_partition_test
f536400 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/run-check_dev

@hawkingrei
remove useless
c9666e9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2022
@hawkingrei hawkingrei requested a review from tisonkun March 3, 2022 11:43
tisonkun
tisonkun reviewed Mar 3, 2022
View reviewed changes
testkit/result.go Outdated Show resolved Hide resolved
tisonkun
tisonkun reviewed Mar 3, 2022
View reviewed changes
testkit/mockstore.go Outdated Show resolved Hide resolved
@tisonkun
revert unnecessary changes
6637e85 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
WithSchemaLease
0c7854e 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 3, 2022
@tisonkun
Copy link
Contributor

tisonkun commented Mar 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0c7854e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2022
@ti-chi-bot
Copy link
Member

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

/run-unit-test

3 similar comments
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 4910b08 into pingcap:master Mar 3, 2022
@hawkingrei hawkingrei deleted the db_partition_test branch March 3, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@xhebox xhebox xhebox approved these changes

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for ddl/db_partition_test.go
5 participants
@hawkingrei @ti-chi-bot @sre-bot @tisonkun @xhebox