-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the join scope with explicit parents (#33311) #33415
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@AilinKid you're already a collaborator in bot's repo. |
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
cherry-pick #33311 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33415
After apply modifications, you can push your change to this PR via:
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #31770
Problem Summary:
What is changed and how it works?
after this pingcap/parser#1129, tidb parser will reorganize join table regardless the explicit parents
Eg: t1 join (t2 join t3) will be reorged as (t1 join t2) join t3
parser/1129 seek to solve the problem
1: with no explicit parents join sequence like: t1 join t2 join t3, make them left-associative
2: with explicit parents and can be reorder the join sequece, like: a join b right join c, we find it here, change the right join as left join, then with the logical semantic same, rewrite it as a join c left join b
Although it's a nice idea, we still has something to do before that, like name resolution in parents scope. like:
select t1.* from t t0 cross join (t t1 join t t2 on 100=t0.a)
t0.a here shouldn't be seen by the join inside. But after it's rewrite it's different
select t1.* from (t t0 cross join t t1) join t t2 on 100=t0.a
this kind of join reorder can be detected and improved in logical optimization.
Check List
Tests
Side effects
Documentation
Release note