Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the join scope with explicit parents (#33311) #33416

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 25, 2022

cherry-pick #33311 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33416

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/33416:release-5.3-59fac2ababb5

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #31770

Problem Summary:

What is changed and how it works?

after this pingcap/parser#1129, tidb parser will reorganize join table regardless the explicit parents
Eg: t1 join (t2 join t3) will be reorged as (t1 join t2) join t3
parser/1129 seek to solve the problem
1: with no explicit parents join sequence like: t1 join t2 join t3, make them left-associative
2: with explicit parents and can be reorder the join sequece, like: a join b right join c, we find it here, change the right join as left join, then with the logical semantic same, rewrite it as a join c left join b

Although it's a nice idea, we still has something to do before that, like name resolution in parents scope. like:
select t1.* from t t0 cross join (t t1 join t t2 on 100=t0.a)
t0.a here shouldn't be seen by the join inside. But after it's rewrite it's different
select t1.* from (t t0 cross join t t1) join t t2 on 100=t0.a

this kind of join reorder can be detected and improved in logical optimization.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 25, 2022
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick labels Mar 25, 2022
@ti-srebot ti-srebot added this to the v5.3.1 milestone Mar 25, 2022
@ti-chi-bot ti-chi-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2022
@ti-srebot
Copy link
Contributor Author

@AilinKid you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2022
@VelocityLight
Copy link

This pull request is closed because the related issue is triaged "Won't Fix".
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants