Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the wrong cost formula of MPPExchanger #35438

Merged
merged 8 commits into from
Jun 17, 2022
Merged

planner: fix the wrong cost formula of MPPExchanger #35438

merged 8 commits into from
Jun 17, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 16, 2022

What problem does this PR solve?

Issue Number: ref #35240

Problem Summary: fix the wrong cost formula of MPPExchanger

What is changed and how it works?

fix the wrong cost formula of MPPExchanger, the net cost part should be rows*row-size*net-factor instead of rows*net-factor.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 added the sig/planner SIG: Planner label Jun 16, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2022

/run-unit-test

@qw4990 qw4990 changed the title [WIP] planner: fix the wrong cost formula of MPPExchanger planner: fix the wrong cost formula of MPPExchanger Jun 16, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2022

/run-unit-test

@qw4990 qw4990 mentioned this pull request Jun 16, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 17, 2022

/run-all-tests

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 17, 2022

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 17, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/588edc433b33aa8b2219a1caba324fb91a22d826

qw4990
qw4990 commented Jun 17, 2022
View reviewed changes
executor/tiflashtest/tiflash_test.go
@@ -281,7 +281,7 @@ func TestMppExecution(t *testing.T) {
require.NoError(t, err)
ts := txn.StartTS()
taskID := tk.Session().GetSessionVars().AllocMPPTaskID(ts)
require.Equal(t, int64(6), taskID)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan changed.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 17, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2022
@hawkingrei
Copy link
Member

/run-check_dev-2

@hawkingrei
Copy link
Member

/run-mysql-test

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 17, 2022

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 588edc4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2022
@ti-chi-bot ti-chi-bot merged commit d3b79de into pingcap:master Jun 17, 2022
@fixdb
Copy link
Contributor

fixdb commented Jun 23, 2022

/run-all-tests

@Yui-Song
Copy link
Contributor

/build

@Yui-Song
Copy link
Contributor

/run-build-arm64 comment=true

qw4990 added a commit that referenced this pull request Jun 24, 2022
@qw4990
Revert "planner: fix the wrong cost formula of MPPExchanger (#35438)"
525703a 
This reverts commit d3b79de.
@qw4990 qw4990 mentioned this pull request Jun 24, 2022
Merged
@Yui-Song Yui-Song mentioned this pull request Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@Yisaer Yisaer Yisaer approved these changes

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@qw4990 @ti-chi-bot @sre-bot @hawkingrei @fixdb @Yui-Song @Yisaer @time-and-fate