executor: fix left join on partition table generate invalid lock key #35732
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6b19f8f2f6abdb8dbbc854488b188674b3c5968d |
|
/run-check_dev_2 |
|
/run-check-issue-triage-complete |
ti-chi-bot
added
needs-cherry-pick-6.0
needs-cherry-pick-release-6.1
mjonss
approved these changes
Jun 27, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 84a75f5
|
ti-chi-bot
added
the
status/can-merge
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 28, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
12 tasks
|
cherry pick to release-6.0 in PR #35773 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 28, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
12 tasks
|
cherry pick to release-6.1 in PR #35774 |
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jun 28, 2022
* upstream/master: (57 commits) types: fix incompatible implementation of jsonpath extraction (pingcap#35320) planner: fix TRACE PLAN TARGET = 'estimation' panic when meeting partition table (pingcap#35743) *: Add `testfork.RunTest` to run multiple tests in one function (pingcap#35746) sessionctx/variable: add tests to ensure skipInit can be removed (pingcap#35703) helper: request another PD if one of them is unavailable (pingcap#35750) metrics: add cached table related metrics to grafana panel (pingcap#34718) expression: use cloned RetType at `evaluateExprWithNull` when it may be changed. (pingcap#35759) executor: fix left join on partition table generate invalid lock key (pingcap#35732) readme: remove adopters (pingcap/docs#8725) (pingcap#35124) *: only add default value for final aggregation to fix the aggregate push down (partition) union case (pingcap#35443) planner: fix the wrong cost formula of MPPExchanger on cost model ver2 (pingcap#35718) sessionctx: support encoding and decoding statement context (pingcap#35688) txn: refactor ts acquisition within build and execute phases (pingcap#35376) ddl: for schema-level DDL method parameter is now XXXStmt (pingcap#35722) *: enable gofmt (pingcap#35721) planner: disable collate clause support for enum or set column (pingcap#35684) *: Provide a util to "pause" session in uint test (pingcap#35529) ddl: implement the core for multi-schema change (pingcap#35429) parser: XXXDatabaseStmt now use CIStr for DB name (pingcap#35668) *: remove real tikv test on github actions (pingcap#35710) ...
ti-chi-bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #28073
Problem Summary:
select * from t1 left join t2 ... for update
t2 is partition table.
In the left join case, the physical column id might be 0,
because when a row in t1 but not in t2, NULL will be filled...
and the physical column ID is not set in the row.
It cause the
for updategenerate the invalid lock key with physical ID = 0What is changed and how it works?
Skip the physical ID = 0 lock key to avoid that case.
Check List
Tests
By the way, I find something seems wrong:
kv storage Scan() API seems don't scan the lock CF... (I'm not sure is it by design? there is also a ScanLock() API used by the GCWorker)
We should use 'begin pessimistic' in the test so the lock key is written before the transaction commit. In optimistic txn mode, the lock key is buffered and written until commit... then the test code can't read that lock
Integration test
Manual test (add detailed scripts or steps below)
No code
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.