telemetry: Initialize telemetry asynchronously #35898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telemetry initialization might take 30 seconds when the route from cluster and service endpoint is slow. It can be made asynchronously without sacrificing anything. Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
ti-chi-bot
added
size/XS
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
sunxiaoguang
changed the title
|
/run-all-tests |
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/57a24cdb8b5a935601c24868923986014973071a |
ngaut
approved these changes
Jul 3, 2022
xhebox
approved these changes
Jul 6, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 3c2719f
|
ti-chi-bot
added
the
status/can-merge
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jul 6, 2022
* upstream/master: (77 commits) infoschema: add a simply store for DM's SchemaTracker (pingcap#35954) planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890) telemetry: Initialize telemetry asynchronously (pingcap#35898) sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733) session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659) *: add telemetry support for multi-schema change (pingcap#35977) topsql: compress plan instead of dropping it (pingcap#35973) *: use pdqsort to improve sort performance (pingcap#34404) ddl: refine GetDDLInfo function (pingcap#35969) *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943) ddl: remove `onDropIndexes` (pingcap#35960) ddl: refine history job code (pingcap#35967) sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256) *: change remote cache (pingcap#35968) *: enable gosec (pingcap#35873) plancodec: fix a miss case in conversion (pingcap#35957) ddl: support drop indexes for multi-schema change (pingcap#35883) pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949) br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147) txn: rename snapshot related methods in txnManager. (pingcap#35912) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry initialization might take 30 seconds when the route from cluster and service endpoint is extremely slow or simply not working. It can be made asynchronously without sacrificing anything.
Signed-off-by: Xiaoguang Sun sunxiaoguang@gmail.com
What problem does this PR solve?
Issue Number: close #35897
Problem Summary:
We discovered TiDB server slow startup, up to 30 seconds, when we run a server in AWS us-west-2 region. I could be the reason that the network to telemetry service endpoint is somewhat slow. Since initialization of telemetry can definitely be asynchronous, it wouldn't affect anything by making TiDB server startup faster.
What is changed and how it works?
Initialize telemetry asynchronously
Check List
Tests
Starting the cluster without this patch took about a minute to finish and only 29 seconds when initialization is done asynchronously.
Side effects: None
Documentation: None
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.