Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: prevent sending cop request for show columns (#36613) #36816

Merged
merged 4 commits into from
Aug 10, 2022
Merged

executor: prevent sending cop request for show columns (#36613) #36816

merged 4 commits into from
Aug 10, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 2, 2022 •
edited
Loading

cherry-pick #36613 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36816

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36816:release-5.2-e39ef4cae80f

What problem does this PR solve?

Issue Number: close #36426, #36496

What is changed and how it works?

This PR prevents running the executor when executing SHOW COLUMNS or reading INFORMATION_SCHEMA.COLUMNS.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-srebot
cherry pick pingcap#36613 to release-5.2
cce8384 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 2, 2022
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.2-cherry-pick labels Aug 2, 2022
@ti-srebot ti-srebot mentioned this pull request Aug 2, 2022
Merged
12 tasks
@ti-srebot ti-srebot added this to the v5.2.4 milestone Aug 2, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2022
@ti-srebot
Copy link
Contributor Author

@tangenta you're already a collaborator in bot's repo.

@xhebox
*: fix CI
1141295 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2022
@xhebox
*: fix CI
6721fe8 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 10, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6721fe8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2022
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented Aug 10, 2022

/run-unit-test

5 similar comments
@xhebox
Copy link
Contributor

xhebox commented Aug 10, 2022

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Aug 10, 2022

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Aug 10, 2022

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Aug 10, 2022

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Aug 10, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/08761db5cdc15d1042c906be9b0e86a2f59b4044

@ti-chi-bot ti-chi-bot merged commit cd95bba into pingcap:release-5.2 Aug 10, 2022
@xhebox xhebox deleted the release-5.2-e39ef4cae80f branch August 10, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@xhebox xhebox xhebox approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @xhebox @sre-bot @xiongjiwei @VelocityLight @tangenta