-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,expression: avoid to append nil to warnings (#36304) #36932
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@zyguan you're already a collaborator in bot's repo. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b1f9baf333948bd6f7570915c7f86f7e1daa75aa |
closed for DMR version |
cherry-pick #36304 to release-6.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36932
After apply modifications, you can push your change to this PR via:
Signed-off-by: zyguan zhongyangguan@gmail.com
What problem does this PR solve?
Issue Number: close #31569
Problem Summary: two issues are described in #31569:
show warnings
.What is changed and how it works?
Previously we always append the warning error even when it's a nil here, which leads to the first issue. This PR uses
sc.HandleTruncate
to handle trancate warnings uniformly and amends warnings generated on inserting.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.