Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support HashJoin cost detail #37012

Merged
merged 21 commits into from
Aug 22, 2022
Merged

planner: support HashJoin cost detail #37012

merged 21 commits into from
Aug 22, 2022
+296 −54

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Aug 10, 2022

What problem does this PR solve?

Issue Number: ref #36962

Problem Summary:

What is changed and how it works?

Support cost detail for hashjoin

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Yisaer
support reader operators cost detail
d9e1d63 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support reader operators cost detail
0b5da58 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
add comment
4ec704f 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
support hashjoin cost detail
a8a5008 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge branch 'master' of https://github.com/pingcap/tidb into add_pla…
ec4e376 
…n_cost_detail_3
@Yisaer
support hashjoin cost detail
a3965be 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8e2ab756ad77652f9af0bc96f29429a6cd813154

@Yisaer
fix lint
62f941e 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
revise code
6c4eeeb 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
revise code
e64f93c 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2022
@hawkingrei
Copy link
Member

/gray-debug

6 similar comments
@wuhuizuo
Copy link
Contributor

/gray-debug

@wuhuizuo
Copy link
Contributor

/gray-debug

@wuhuizuo
Copy link
Contributor

/gray-debug

@wuhuizuo
Copy link
Contributor

/gray-debug

@wuhuizuo
Copy link
Contributor

/gray-debug

@wuhuizuo
Copy link
Contributor

/gray-debug

@wuhuizuo
Copy link
Contributor

/gray-debug rerun because of goproxy network issue

@wuhuizuo
Copy link
Contributor

/gray-debug

3 similar comments
@wuhuizuo
Copy link
Contributor

/gray-debug

@wuhuizuo
Copy link
Contributor

/gray-debug

@wuhuizuo
Copy link
Contributor

/gray-debug

@Yisaer
address the comment
b795817 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
address the comment
fb38188 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge branch 'master' into add_plan_cost_detail_3
24172a1
@Yisaer
address the comment
4798b92 
Signed-off-by: yisaer <disxiaofei@163.com>
@hawkingrei
Copy link
Member

/run-unit-test

time-and-fate
time-and-fate reviewed Aug 21, 2022
View reviewed changes
planner/core/plan_cost_detail.go
AddParam(DiskCostDescLbl, diskCostDetail.desc()).
AddParam(ProbeDiskCostDescLbl, diskCostDetail.probeDesc())

detail.SetDesc(fmt.Sprintf("%s+%s+%s+all children cost", CPUCostDetailLbl, MemCostDetailLbl, DiskCostDetailLbl))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that in previous PRs, each label in the Desc corresponds to exactly one value in the Param with the same label. But this PR doesn't follow this.
For example, we didn't explain the relationship between CPUCostDetailLbl, CPUCostDescLbl, and ProbeCostDescLbl.
Would we improve this sometime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently no, we may ignore this in interval server and revise it in dashboard.

@Yisaer
address the comment
62040c2 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge branch 'add_plan_cost_detail_3' of https://github.com/Yisaer/tidb…
f1b6216 
… into add_plan_cost_detail_3
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 22, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f1b6216

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 22, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6adc272

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@ti-chi-bot ti-chi-bot merged commit e0da196 into pingcap:master Aug 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 17 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 9 min 6 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 36 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 35 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 5 min 20 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 5 min 20 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yisaer @ti-chi-bot @sre-bot @hawkingrei @wuhuizuo @time-and-fate