Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: set tiflash placement group index to 120 #37179

Merged
merged 6 commits into from
Aug 19, 2022
Merged

ddl: set tiflash placement group index to 120 #37179

merged 6 commits into from
Aug 19, 2022
+123 −1

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #37171

What is changed and how it works?

  1. Set the group_index of placement rule group 'tiflash' to 120 when adding a tiflash placement rule.
  2. Fix the group_index in PollTiFlashRoutine when the background task started for old cluster.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Manual test1:

  1. Create a table with tiflash replica in the old cluster.
  2. Upgrade one tidb instance of the cluster to the code of this PR, the tiflash group_index was fixed to 120.

Manual test2:

  1. Setup a new cluster with the code of this PR.
  2. Create a new table with tiflash replica, the tiflash group_index is 120.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2f1f2366c3f8cc11b58c867f378614818be63db8

CalvinNeo
CalvinNeo approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@CalvinNeo: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

bb7133
bb7133 reviewed Aug 18, 2022
View reviewed changes
ddl/ddl_tiflash_test.go Outdated Show resolved Hide resolved
@bb7133
Copy link
Member

bb7133 commented Aug 18, 2022

Fix the group_index in PollTiFlashRoutine when the background task started for old cluster.

@lcwangchao @CalvinNeo Will this change any other behaviors related to TiFlash replicas?

@lcwangchao
Copy link
Collaborator Author

Fix the group_index in PollTiFlashRoutine when the background task started for old cluster.

@lcwangchao @CalvinNeo Will this change any other behaviors related to TiFlash replicas?

I think it will have no other effects. @CalvinNeo Can you make a confirm again?

bb7133
bb7133 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2022
@bb7133
Copy link
Member

bb7133 commented Aug 19, 2022

/merge

@ti-chi-bot
Copy link
Member

@bb7133: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 19, 2022

/merge

1 similar comment
@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2f1f236

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2022
@ti-chi-bot ti-chi-bot merged commit d1f75f0 into pingcap:master Aug 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 19, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 7 min 10 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 38 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 34 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 6 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 47 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@lcwangchao lcwangchao added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Oct 14, 2022
@lcwangchao
Copy link
Collaborator Author

/run-cherry-picker

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2022
Merged
2 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38476.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 14, 2022
@lcwangchao @ti-chi-bot
This is an automated cherry-pick of pingcap#37179
2edbf4d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Oct 14, 2022
@ti-chi-bot
ddl: set tiflash placement group index to 120 (#37179) (#38476)
544e759 
ref #37171
lcwangchao pushed a commit to lcwangchao/tidb that referenced this pull request Oct 14, 2022
@ti-chi-bot @lcwangchao
ddl: set tiflash placement group index to 120 (pingcap#37179) (pingca…
9be8759 
…p#38476)

ref pingcap#37171
@lcwangchao lcwangchao mentioned this pull request Oct 14, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Oct 14, 2022
@lcwangchao
*: cherry pick #37252 #37179 (#38481)
852d31d 
ref #37171
@lcwangchao lcwangchao deleted the tiflash_group_index branch November 7, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcwangchao @ti-chi-bot @sre-bot @bb7133 @xhebox @CalvinNeo