*: change integration.BeforeTest to integration.BeforeTestExternal to avoid skip tests
#37341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` to avoid skip tests
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
/run-unit-test |
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e8ad502e6110db3941bb46b0e1bdd97b44668f97 |
|
/run-mysql-test tidb-test=pr/1937 |
lcwangchao
commented
Aug 25, 2022
| @@ -40,11 +40,13 @@ import ( | |||
| ) | |||
|
|
|||
| func TestInfo(t *testing.T) { | |||
| t.Skip("TestInfo will hang currently, it should be fixed later") | |||
There was a problem hiding this comment.
After concurrent ddl merged, this tests will fail for many reasons. I have to skip it temporarily. @wjhuang2016
wjhuang2016
approved these changes
Aug 25, 2022
|
/run-mysql-test tidb-test=pr/1937 |
hawkingrei
approved these changes
Aug 25, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 2bc75a8
|
ti-chi-bot
added
the
status/can-merge
|
/run-mysql-test tidb-test=pr/1937 |
TiDB MergeCI notify
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Aug 27, 2022
…verage * upstream/master: (109 commits) *: rename TemporaryTableAttachedInfoSchema (pingcap#37408) *: enable noloopclosure (pingcap#37153) executor: add JSON opaque value condition to everywhere (pingcap#37390) *: refine mock session manager (pingcap#37400) lightning: check counter value to make code more robust (pingcap#37380) *: use go 1.19 (pingcap#36223) br: restore tiflash replica count after PiTR (pingcap#37181) testkit,executor: add MustQueryWitnContext API and fix unstable test TestCoprocessorPriority (pingcap#37382) executor: add conversion to opaque value for json_objectagg and json_arrayagg (pingcap#37337) expression: quote json path if necessarily (pingcap#37375) *: support ACCOUNT (UN)LOCK when creating/altering user (pingcap#37052) log-backup: support the ddl(exchange partition) when PiTR (pingcap#37050) *: change `integration.BeforeTest` to `integration.BeforeTestExternal` to avoid skip tests (pingcap#37341) executor: fix unstable TestGlobalMemoryTrackerOnCleanUp (pingcap#37372) util/ranger: avoid building ranges twice in detachCNFCondAndBuildRangeForIndex (pingcap#37177) statistics: track used stats status during query (pingcap#37101) *: fix data race in `TestTiFlashGroupIndexWhenStartup` (pingcap#37371) lightning: fix dpanic log when init session vars (pingcap#37301) executor: let plan replayer record table tiflash replica (pingcap#37336) types: fix a bug in casting str2str when `union` (pingcap#37242) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #37340
What is changed and how it works?
Change
integration.BeforeTesttointegration.BeforeTestExternalto avoid skip testsCheck List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.