Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong result when enabling dynamic mode in partition table for tiflash #37442

Merged
merged 4 commits into from
Aug 30, 2022
Merged

planner: fix wrong result when enabling dynamic mode in partition table for tiflash #37442

merged 4 commits into from
Aug 30, 2022

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Aug 29, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #37254

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix wrong result when enabling dynamic mode in partition table for tiflash

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 29, 2022 •
edited by sre-bot
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/68741c63a6a57cb2d15761380aefa8c7f99d68ee

windtalker
windtalker reviewed Aug 30, 2022
View reviewed changes
planner/core/fragment.go Outdated
} else {
for i, def := range pi.Definitions {
if def.Name.L == partitionNames[0].L {
ret = []table.PhysicalTable{tbl.GetPartition(pi.Definitions[i].ID)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just use ret = []table.PhysicalTable{tbl.GetPartition(def.ID)} here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

windtalker
windtalker approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 30, 2022
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Aug 30, 2022
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 625a91f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #37449

@ti-srebot ti-srebot mentioned this pull request Aug 30, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 30, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#37442 to release-5.1
f0d5b54 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #37451

@sre-bot
Copy link
Contributor

sre-bot commented Aug 30, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 14 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 14 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 34 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 6 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 36 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 23 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 27 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 27 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@ti-srebot ti-srebot mentioned this pull request Aug 30, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 30, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#37442 to release-5.2
35659d9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #37453

@ti-srebot ti-srebot mentioned this pull request Aug 30, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 30, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#37442 to release-5.3
975a096 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #37454

@ti-srebot ti-srebot mentioned this pull request Aug 30, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 30, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#37442 to release-5.4
be4614a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #37456

@ti-srebot ti-srebot mentioned this pull request Aug 30, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 30, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#37442 to release-6.0
cc8b1e8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #37457

@ti-srebot ti-srebot mentioned this pull request Aug 30, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 30, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#37442 to release-6.1
4e5a219 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #37458

@ti-srebot ti-srebot mentioned this pull request Aug 30, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 30, 2022
@wshwsh12 @ti-srebot
cherry pick pingcap#37442 to release-6.2
babb99c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #37460

ti-chi-bot pushed a commit that referenced this pull request Aug 31, 2022
@ti-srebot
planner: fix wrong result when enabling dynamic mode in partition tab…
e20aaeb 
…le for tiflash (#37442) (#37449)

close #37254
ti-chi-bot pushed a commit that referenced this pull request Aug 31, 2022
@ti-srebot
planner: fix wrong result when enabling dynamic mode in partition tab…
9661084 
…le for tiflash (#37442) (#37451)

close #37254
ti-chi-bot pushed a commit that referenced this pull request Aug 31, 2022
@ti-srebot
planner: fix wrong result when enabling dynamic mode in partition tab…
473cae5 
…le for tiflash (#37442) (#37454)

close #37254
ti-chi-bot pushed a commit that referenced this pull request Aug 31, 2022
@ti-srebot
planner: fix wrong result when enabling dynamic mode in partition tab…
1167181 
…le for tiflash (#37442) (#37456)

close #37254
ti-chi-bot pushed a commit that referenced this pull request Aug 31, 2022
@ti-srebot
planner: fix wrong result when enabling dynamic mode in partition tab…
937b8ff 
…le for tiflash (#37442) (#37453)

close #37254
ti-chi-bot pushed a commit that referenced this pull request Sep 19, 2022
@ti-srebot
planner: fix wrong result when enabling dynamic mode in partition tab…
61b728d 
…le for tiflash (#37442) (#37458)

close #37254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tiflash return wrong results when enabling dynamic mode in partition table
6 participants
@wshwsh12 @ti-chi-bot @ti-srebot @sre-bot @windtalker @XuHuaiyu