Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: update autoid cache step to avoid enabling experimental feature #39051

Closed
wants to merge 2 commits into from
Closed

lightning: update autoid cache step to avoid enabling experimental feature #39051

wants to merge 2 commits into from

Conversation

sleepymole
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #38956

Problem Summary:
#38442 added special logic for auto cache step 1. It's still an experimental feature.

What is changed and how it works?

Set autoid cache step to 2.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2022
@sleepymole sleepymole added component/lightning This issue is related to Lightning of TiDB. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2022
@sleepymole
Copy link
Contributor Author

/run-integration-br-test

@lichunzhu
Copy link
Contributor

/run-integration-br-test

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2022
lichunzhu added a commit to lichunzhu/tidb that referenced this pull request Nov 10, 2022
@lichunzhu
cherry-pick pingcap#39051
4863a2c
@sleepymole
Copy link
Contributor Author

Replaced by #39010.

@sleepymole sleepymole closed this Nov 10, 2022
@sleepymole sleepymole deleted the issue-38956 branch November 10, 2022 08:03
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 10, 2022
@lichunzhu @ti-chi-bot
cherry-pick pingcap#39051
aabcd13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@lance6716 lance6716 Awaiting requested review from lance6716

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sleepymole @ti-chi-bot @lichunzhu