Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add foreign key test for br #39427

Merged
merged 18 commits into from
Nov 30, 2022
Merged

br: add foreign key test for br #39427

merged 18 commits into from
Nov 30, 2022

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: add foreign key test for br

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
init
2622984 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
add check
09a085e
@crazycs520 crazycs520 added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 28, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • fengou1

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2022
@crazycs520
Copy link
Contributor Author

/run-all-tests

@3pointer
Copy link
Contributor

/run-integration-br-tests

@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@crazycs520
fix ci
d628c09 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Merge branch 'master' into fk-br-test
6255c9b
@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@crazycs520
fix test
64c9e05 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@crazycs520
add test
2da5825 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
fengou1
fengou1 reviewed Nov 30, 2022
View reviewed changes
br/pkg/gluetidb/glue.go Outdated Show resolved Hide resolved
@crazycs520
address comment
08a75b8 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3573e4d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit f5487e3 into pingcap:master Nov 30, 2022
@crazycs520 crazycs520 deleted the fk-br-test branch November 30, 2022 11:01
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 6 min 59 sec New failing
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 41 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 5 min 1 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 20 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 35 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 5 min 43 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@crazycs520 crazycs520 mentioned this pull request Dec 5, 2022
Merged
12 tasks
@crazycs520 crazycs520 mentioned this pull request Feb 1, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengou1 fengou1 fengou1 approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crazycs520 @ti-chi-bot @3pointer @sre-bot @YuJuncen @fengou1