Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: implement ttl job schedule framework (#39472) #39830

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39472

What problem does this PR solve?

Issue Number: close #39471

Problem Summary:

Implement a ttl job schedule framework. It reads information from the info schema and the mysql.tidb_ttl_table_status, gets the job to run and schedule them to a scan worker.

The implementation of variable settings, scanWorker and delWorker are left for future development.

What is changed and how it works?

For most parts, the job manager is split from the original demo: https://github.com/pingcap/tidb/pull/39320/files. It implements the following feature:

  1. The most fundamental one. Let the job run on the worker.
  2. Support graceful shutdown with the context from domain.
  3. Allow collecting the errors from the tasks, and storing them into the table when the job is finished.
  4. Allow cancelling the running jobs.

This pr left a lot of TODO for system variables. They are left in #39727.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. affects-6.5 release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 12, 2022
@wuhuizuo
Copy link
Contributor

/run-build

1 similar comment
@wuhuizuo
Copy link
Contributor

/run-build

@wuhuizuo
Copy link
Contributor

/run-all-tests

1 similar comment
@wuhuizuo
Copy link
Contributor

/run-all-tests

@YangKeao YangKeao mentioned this pull request Dec 16, 2022
60 tasks
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 19, 2022
@YangKeao YangKeao force-pushed the cherry-pick-39472-to-release-6.5 branch from 97f8307 to 8892bc3 Compare December 20, 2022 02:44
@YangKeao
Copy link
Member

This PR depends on #39775

@YangKeao YangKeao force-pushed the cherry-pick-39472-to-release-6.5 branch from 8892bc3 to ee09fed Compare December 20, 2022 03:46
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2022
@YangKeao
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ee09fed

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 06290cd into pingcap:release-6.5 Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants