Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: remove useless error log #41107

Merged
merged 9 commits into from
Feb 6, 2023
Merged

ddl: remove useless error log #41107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6378d64
ddl: remove useless error log
zimulala Feb 6, 2023
819b0aa
ddl: update build.bazel
zimulala Feb 6, 2023
2b5e3fc
Merge branch 'master' into zimuxia/rm-err-log
ti-chi-bot Feb 6, 2023
5d173b6
Merge branch 'master' into zimuxia/rm-err-log
hawkingrei Feb 6, 2023
89b7f9d
Merge branch 'master' into zimuxia/rm-err-log
hawkingrei Feb 6, 2023
dc5bf01
Merge branch 'master' into zimuxia/rm-err-log
ti-chi-bot Feb 6, 2023
bd90be6
Merge branch 'master' into zimuxia/rm-err-log
ti-chi-bot Feb 6, 2023
200d4ca
Merge branch 'master' into zimuxia/rm-err-log
hawkingrei Feb 6, 2023
b1c4bb6
Merge branch 'master' into zimuxia/rm-err-log
ti-chi-bot Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ddl/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ go_library(
"//util/filter",
"//util/gcutil",
"//util/generic",
"//util/gpool",
"//util/gpool/spmc",
"//util/hack",
"//util/intest",
Expand Down
3 changes: 2 additions & 1 deletion ddl/dist_backfilling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"github.com/pingcap/tidb/table"
"github.com/pingcap/tidb/util"
"github.com/pingcap/tidb/util/dbterror"
"github.com/pingcap/tidb/util/gpool"
"github.com/pingcap/tidb/util/gpool/spmc"
"github.com/pingcap/tidb/util/logutil"
"go.uber.org/zap"
Expand Down Expand Up @@ -258,7 +259,7 @@ func GetTasks(d *ddlCtx, sess *session, tbl table.Table, runningJobID int64, con
// TODO: add test: if all tidbs can't get the unmark backfill job(a tidb mark a backfill job, other tidbs returned, then the tidb can't handle this job.)
if dbterror.ErrDDLJobNotFound.Equal(err) {
logutil.BgLogger().Info("no backfill job, handle backfill task finished")
return nil, err
return nil, gpool.ErrProducerClosed
}
if kv.ErrWriteConflict.Equal(err) {
logutil.BgLogger().Info("GetAndMarkBackfillJobsForOneEle failed", zap.Error(err))
Expand Down