Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support error handling for distributed adding index #43075

Merged
merged 30 commits into from
Apr 20, 2023
Merged

*: support error handling for distributed adding index #43075

merged 30 commits into from
Apr 20, 2023

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Apr 14, 2023 •
edited by tangenta
Loading

What problem does this PR solve?

Issue Number: close #43029, close #42436
Problem Summary:
This PR supports error handling for distributed adding index.
It

  1. modify the task tables in distribute framework, adding the error field.
  2. adjust the framework to record the subtask's error.
  3. do unsafeImport when finishing a partition when adding an index.
  4. check the remote duplicate key if it's the unique index.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@wjhuang2016
init
4af1dd9 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
add test
a5afd61 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
8d40d96 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
refine
b53ada0 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
done
263f51b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
c32e093 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
e8f2051 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'master' of github.com:pingcap/tidb into add_index_suppo…
4755c91 
…rt_error
@wjhuang2016
save
fe932f4 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 wjhuang2016 requested a review from a team as a code owner April 14, 2023 11:48
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2023
@wjhuang2016
test
a3a5810 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2023
@wjhuang2016
merge
76aba58 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
done
061e8a9 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
2346fc4 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
3922508 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix test
2f31502 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
a2e1c75 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
1b4634f 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix test
09cdc83 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
708bae9 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix
9dcf1ee 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Copy link
Member Author

/retest

1 similar comment
@wjhuang2016
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 20, 2023
@ti-chi-bot
Copy link
Member

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wjhuang2016
merge
df6c7b4 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2023
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: df6c7b4

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Apr 20, 2023
@hawkingrei
Copy link
Member

/retest

@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot merged commit 2021b31 into pingcap:master Apr 20, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 20, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43250.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 20, 2023
@wjhuang2016 @ti-chi-bot
This is an automated cherry-pick of pingcap#43075
f4f0667 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@wjhuang2016
Copy link
Member Author

/run-cherry-picker

2 similar comments
@wjhuang2016
Copy link
Member Author

/run-cherry-picker

@wjhuang2016
Copy link
Member Author

/run-cherry-picker

@wjhuang2016
Copy link
Member Author

/cherry-pick 7.1

@ti-chi-bot
Copy link
Member

@wjhuang2016: cannot checkout 7.1: error checking out 7.1: exit status 1. output: error: pathspec '7.1' did not match any file(s) known to git

In response to this:

/cherry-pick 7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wjhuang2016
Copy link
Member Author

/cherry-pick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 20, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@wjhuang2016: new pull request created to branch release-7.1: #43263.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 20, 2023
@wjhuang2016 @ti-chi-bot
*: support error handling for distributed adding index (pingcap#43075)
6e93304 
close pingcap#42436, close pingcap#43029
ti-chi-bot added a commit that referenced this pull request Apr 21, 2023
@ti-chi-bot
*: support error handling for distributed adding index (#43075) (#43263)
0291f22 
close #42436, close #43029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@wjhuang2016 @ti-chi-bot @tangenta @hawkingrei @XuHuaiyu @Benjamin2037