Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partition: fix split and scatter region for truncate partition #43271

Merged
merged 6 commits into from
May 12, 2023
Merged

partition: fix split and scatter region for truncate partition #43271

merged 6 commits into from
May 12, 2023

Conversation

jiyfhust
Copy link
Contributor

@jiyfhust jiyfhust commented Apr 21, 2023 •
edited by CbcWestwolf
Loading

What problem does this PR solve?

Issue Number: close #43174 close #43028

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 21, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • mjonss

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Apr 21, 2023
@ti-chi-bot
Copy link
Member

Hi @jiyfhust. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 21, 2023
mjonss
mjonss reviewed Apr 24, 2023
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
@mjonss
Copy link
Contributor

mjonss commented Apr 26, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 26, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 8, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2023
Defined2014
Defined2014 reviewed May 11, 2023
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
@jiyfhust jiyfhust force-pushed the scatter_region_for_truncate_partition branch from 33e7ce2 to 53173bb Compare May 12, 2023 01:15
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2023
@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d22b4ce

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2023
@Defined2014
Copy link
Contributor

/retest

@Defined2014 Defined2014 removed needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels May 12, 2023
@wuhuizuo
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 3e4538d into pingcap:master May 12, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43742.

@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43743.

@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #43744.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 12, 2023
@jiyfhust @ti-chi-bot
This is an automated cherry-pick of pingcap#43271
60185a6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 18, 2023
@ti-chi-bot
partition: fix split and scatter region for truncate partition (#43271)…
2561314 
… (#43743)

close #43028, close #43174
ti-chi-bot bot pushed a commit that referenced this pull request May 26, 2023
@ti-chi-bot
partition: fix split and scatter region for truncate partition (#43271)…
da4eb8b 
… (#43742)

close #43028, close #43174
ti-chi-bot bot pushed a commit that referenced this pull request Jun 26, 2023
@ti-chi-bot
partition: fix split and scatter region for truncate partition (#43271)…
bfae719 
… (#43744)

close #43028, close #43174
@jiyfhust jiyfhust deleted the scatter_region_for_truncate_partition branch July 28, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@mjonss mjonss mjonss approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@jiyfhust @ti-chi-bot @mjonss @Defined2014 @wuhuizuo