Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: add traffic metrics for staleread traffic #43324

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

you06
Copy link
Contributor

@you06 you06 commented Apr 23, 2023

What problem does this PR solve?

Issue Number: close #43325

Problem Summary:

What is changed and how it works?

With tikv/client-go#776, we can display the following metrics:

Before 15:15, the stale-read hit ratio is high, and after 15:15, there are over 80% stale-read misses. From the metrics, we can clearly find the traffic used by stale-read.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add traffic metrics for stale-read.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 23, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 23, 2023
metrics/grafana/tidb.json Outdated Show resolved Hide resolved
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
@you06 you06 force-pushed the stale-read-traffic-metric branch from 3494696 to 791edd0 Compare April 27, 2023 08:35
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2023
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ee32c5e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2023
@you06
Copy link
Contributor Author

you06 commented Apr 28, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit e9184f7 into pingcap:master Apr 28, 2023
@you06
Copy link
Contributor Author

you06 commented May 26, 2023

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@you06: new pull request created to branch release-6.5: #44209.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 26, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@you06
Copy link
Contributor Author

you06 commented May 29, 2023

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@you06: new pull request created to branch release-7.1: #44252.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 29, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stale-read traffic metrics
4 participants