Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix correctness of the correlated predicate push down for cte (#43759) | tidb-test=pr/2143 #43790

Merged
merged 2 commits into from
May 31, 2023
Merged

planner: fix correctness of the correlated predicate push down for cte (#43759) | tidb-test=pr/2143 #43790

merged 2 commits into from
May 31, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43759

What problem does this PR solve?

Issue Number: close #43645

Problem Summary:

The predicate push-down might change the correlated status of the CTE. Our current implementation will cause the wrong result.

What is changed and how it works?

We disable that case's pushing down first.
I will support it later.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that pushing the correlated filter into CTE might cause the wrong result.

@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#43759
c488cf2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 13, 2023
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels May 13, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2023
@winoros winoros changed the title planner: fix correctness of the correlated predicate push down for cte | tidb-test=pr/2128 (#43759) planner: fix correctness of the correlated predicate push down for cte (#43759) | tidb-test=pr/2143 May 31, 2023
@winoros
Copy link
Member

winoros commented May 31, 2023

/retest

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2023
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c488cf2

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels May 31, 2023
@winoros winoros force-pushed the cherry-pick-43759-to-release-6.5 branch from 64d2cf7 to f791dc5 Compare May 31, 2023 09:01
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2023
@winoros
Copy link
Member

winoros commented May 31, 2023

/test mysql-test

@winoros
Copy link
Member

winoros commented May 31, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f791dc5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit a962a6d into pingcap:release-6.5 May 31, 2023
winoros pushed a commit to winoros/tidb that referenced this pull request May 31, 2023
@ti-chi-bot @winoros
planner: fix correctness of the correlated predicate push down for cte (
c7d1f4b 
pingcap#43759) (pingcap#43790)

close pingcap#43645
@winoros winoros mentioned this pull request May 31, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees

@winoros winoros

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @winoros @zimulala @wjhuang2016 @time-and-fate @VelocityLight