remove the dependence between tables and table #44

astaxie · 2015-09-07T11:07:26Z

As tables is the implement of table. So tables like the drivers, while
table like database/sql. while drivers need to regiester in the init.

As tables is the implement of table. So tables like the drivers, while table like database/sql. while drivers need to regiester in the init.

c4pt0r · 2015-09-07T11:59:28Z

infoschema/infoschema.go

@@ -22,6 +22,7 @@ import (
 	"github.com/pingcap/tidb/meta/autoid"
 	"github.com/pingcap/tidb/model"
 	"github.com/pingcap/tidb/table"
+	_ "github.com/pingcap/tidb/table/tables"


any elegant way to do this?

It's the best way for implement and interface.

the same style as database/sql

import "database/sql" import _ "github.com/go-sql-driver/mysql" db, err := sql.Open("mysql", "user:password@/dbname")

golint reports
"infoschema.go:25:2: a blank import should be only in a main or test package, or have a comment justifying it"

@coocood good catch. astaxie@bb78a34

ngaut · 2015-09-07T13:14:32Z

LGTM

remove the dependence between tables and table

c4pt0r · 2015-09-07T13:20:08Z

LGTM

I found dep is hard to use so I switch to glide. Maybe someday we will switch to vgo, the ongoing official go vendor management tool. After updating vendor, then build parser so we don't need to build parser.go(everytime) in tidb repo and then copy the parser.go to vendor, and finally clean up the useless files. Besides, both tidb and lightning use logrus as log lib, and they share a same logger before, but we don't need tidb logging. So I set up a new logger for lightning.

* update tidb-tools * update pd dependency * fix make * fix ci

* update reference to client, GetKeyspaceID -> GetKeyspace Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>

* init * audit: init first version of audit log * audit: support log global rotate * audit: update log keys * audit: more common notify implement * audit: add record id * audit: rename some names * audit: default use normal log path * audit: add server ip info * audit: do some refine * audit: Add some log keys * audit: update some item format * audit: add stmt demo * audit: support redact * audit: fix bug * audit: update filter * audit: update filter * audit: check user * audit: update * update * audit: update * audit: fix bug * aduit: update * audit: update * update * update * audit: add filter unit test * fmt * Add tests for `tidb_audit_enabled` and `tidb_audit_log` * Add tests for `tidb_audit_log_max_size` and `tidb_audit_log_max_lifetime` * Add tests for `tidb_audit_log_reserved_*` * TODO: TestAuditLogRedact * Fininsh `TestAuditLogRedact` * Update (pingcap#1) * fix typo (pingcap#2) * Add `TRANSACTION` * rename sysvar * audit_log_create_filter, audit_log_remove_filter * finish function call and table test * test privilege * finish test for sysvar * TODO: TestConnectionEvenClass * update * audit: fix lint for audit log (pingcap#1) * audit: fix UT failure caused by the change of redact log (pingcap#3) * audit: use `t.TempDir()` to make test stable (pingcap#4) * audit: fix test failed for 7.1 * Add `OWNERS` file (pingcap#35) Co-authored-by: Chao Wang <cclcwangchao@hotmail.com> * audit: fix panic when logging sometime (pingcap#26) (pingcap#31) * test: fix unstable test TestAuditLogReservedDays (pingcap#8) * Format sysvar_test.go * audit: use `StatementContext` to generate redacted SQL (pingcap#9) * audit: fix panic when logging sometime (pingcap#26) * update * add owner * Update OWNERS --------- Co-authored-by: CbcWestwolf <1004626265@qq.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> * audit: fix panic sometimes when `create user` without password (pingcap#37) (pingcap#39) * This is an automated cherry-pick of pingcap#37 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflict --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: 王超 <cclcwangchao@hotmail.com> * extension/audit: introduce serverless audit log Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * update bazel config Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * support enable audit log when activate Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * add gwconnid to audit log Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * comment unstable test * update bazel * add log about activate request * diff audit log enabled * audit: fix memory leak for executeSQL (pingcap#44) (pingcap#45) * This is an automated cherry-pick of pingcap#44 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * Update util.go --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: 王超 <cclcwangchao@hotmail.com> * Update extension/serverless/OWNERS --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> Co-authored-by: Chao Wang <cclcwangchao@hotmail.com> Co-authored-by: cbcwestwolf <1004626265@qq.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: zzm <zhouzemin@pingcap.com> Co-authored-by: Yuqing Bai <baiyuq@gmail.com>

* add min reigon number * sync with upstream

remove the dependence between tables and table

262082b

As tables is the implement of table. So tables like the drivers, while table like database/sql. while drivers need to regiester in the init.

c4pt0r reviewed Sep 7, 2015
View reviewed changes

make golint happy

bb78a34

ngaut added a commit that referenced this pull request Sep 7, 2015

Merge pull request #44 from astaxie/master

81db754

remove the dependence between tables and table

ngaut merged commit 81db754 into pingcap:master Sep 7, 2015

sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019

YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021

update tidb-tools (pingcap#44)

ade02e7

* update tidb-tools * update pd dependency * fix make * fix ci

xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021

[parser] parser: add driver import check & example (pingcap#44)

5c03523

xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021

[parser] parser: add driver import check & example (pingcap#44)

a08c8a5

ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021

[parser] parser: add driver import check & example (#44)

e5fb49c

iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Oct 31, 2022

update reference to client (pingcap#44)

e68d581

* update reference to client, GetKeyspaceID -> GetKeyspace Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>

mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024

[lightning] add minRegionNum parameter (pingcap#44)

ac67ddf

* add min reigon number * sync with upstream

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove the dependence between tables and table #44

remove the dependence between tables and table #44

astaxie commented Sep 7, 2015

c4pt0r Sep 7, 2015

astaxie Sep 7, 2015

coocood Sep 7, 2015

astaxie Sep 7, 2015

ngaut commented Sep 7, 2015

c4pt0r commented Sep 7, 2015

remove the dependence between tables and table #44

remove the dependence between tables and table #44

Conversation

astaxie commented Sep 7, 2015

c4pt0r Sep 7, 2015

Choose a reason for hiding this comment

astaxie Sep 7, 2015

Choose a reason for hiding this comment

coocood Sep 7, 2015

Choose a reason for hiding this comment

astaxie Sep 7, 2015

Choose a reason for hiding this comment

ngaut commented Sep 7, 2015

c4pt0r commented Sep 7, 2015