-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conn: add write timeout for conn which receive a kill signal #44010
Conversation
Signed-off-by: AilinKid <314806019@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: AilinKid <314806019@qq.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 776747c
|
/hold |
We need a wakeable write data implementation when a blocking write data has occurred. |
We have interspersed the Next interface call in the interval of write data with chunk as the unit to realize the detection of kill signal, but the blocking problem of write-data itself is still an important solution to this problem, and default timeout may not be a good solution way of blocking. Considering that this problem only occurs when the network is extremely poor, temporarily close if there is no elegant solution. (chinese explanation: 我们已经在以 chunk 为单元的 write data 的间隔中穿插了 Next 接口调用来实现 kill signal 的检测,但是 write-data 自身的阻塞问题是仍然是这个问题的重要解,default timeout 可能并不是一个好的解除阻塞的方式,考虑到这问题只有在网络极差的情况下才发生,没有优雅解法的情况下暂时close) |
What problem does this PR solve?
Issue Number: close #44009
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.