-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add CTEProducer that shared by all CTEExec (#44643) | tidb-test=pr/2135 #44836
Merged
ti-chi-bot
merged 5 commits into
pingcap:release-6.1-20230515-v6.1.6
from
ti-chi-bot:cherry-pick-44643-to-release-6.1-20230515-v6.1.6
Jun 20, 2023
Merged
executor: add CTEProducer that shared by all CTEExec (#44643) | tidb-test=pr/2135 #44836
ti-chi-bot
merged 5 commits into
pingcap:release-6.1-20230515-v6.1.6
from
ti-chi-bot:cherry-pick-44643-to-release-6.1-20230515-v6.1.6
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-6.1-20230515-v6.1.6
labels
Jun 20, 2023
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
guo-shaoge
changed the title
executor: add CTEProducer that shared by all CTEExec (#44643)
executor: add CTEProducer that shared by all CTEExec (#44643) | tidb-test=pr/2135
Jun 20, 2023
wshwsh12
previously approved these changes
Jun 20, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Jun 20, 2023
/test mysql-test |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Also cherry pick #44782 |
AilinKid
approved these changes
Jun 20, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Jun 20, 2023
XuHuaiyu
approved these changes
Jun 20, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-6.1-20230515-v6.1.6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #44643 #44782
What problem does this PR solve?
Issue Number: close #44649
Problem Summary: As issue comment said: #44649 (comment)
What is changed and how it works?
Before: For different CTE references(a.k.a.
CTEExec
) that use one CTE definition. They will only have one PhysicalPlan of the CTE defition. But we will build CTE definition multiple time for each CTE references.After: Add
CTEProducer
struct, it corresponsds to CTE defition and will only build once. These differentCTEExec
will read from the sameCTEProducer
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.